Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28393 )
Change subject: mb/lenovo: Dual Graphics for xx20/xx30 ThinkPads ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/28393/2/src/mainboard/lenovo/t430s/romstage.... File src/mainboard/lenovo/t430s/romstage.c:
https://review.coreboot.org/#/c/28393/2/src/mainboard/lenovo/t430s/romstage.... PS2, Line 72: enum hybrid_graphics_req mode = HYBRID_GRAPHICS_INTEGRATED;
Well, here https://review.coreboot. […]
Sorry for the confusion. Yes there's no hybrid graphics mux. In general it's discouraged to duplicate code. By using the proposed devicetree settings it does the same. I understand your argument of not using the driver as there's no hybrid graphics to avoid confusion. In that case please keep the code, but also rename the CMOS for t430s to something like "enable_dual_graphics". Otherwise end users will wonder why "discrete only" is missing and report it as a bug.
-
Patrick Rudolph (Code Review)