Attention is currently required from: Hung-Te Lin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56764 )
Change subject: soc/mediatek/mt8195: Add devapc basic drivers ......................................................................
Patch Set 1:
(34 comments)
File src/soc/mediatek/mt8195/devapc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/62247c2d_dbbcbfbb PS1, Line 44: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/e30e61b9_6974a333 PS1, Line 51: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/fe3155b9_63a8d72b PS1, Line 63: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/31df1a4b_7693aa17 PS1, Line 67: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/f58a67db_00a1bae2 PS1, Line 69: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/b48eb0a0_98756a7a PS1, Line 88: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/6ec09f6d_370ceba3 PS1, Line 1282: SEC_RW_ONLY, FORBIDDEN15), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/5f8f8cc8_d4646c8c PS1, Line 1282: SEC_RW_ONLY, FORBIDDEN15), please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/474ef746_83124a0a PS1, Line 1282: SEC_RW_ONLY, FORBIDDEN15), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/c7dfca2e_a2b34871 PS1, Line 1439: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/70adc9e5_75d03514 PS1, Line 1477: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/5effa49a_1fbfcdde PS1, Line 1477: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/52700756_1b367852 PS1, Line 1477: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/d9238040_e09e998c PS1, Line 1477: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/ed8a177c_eaf8349c PS1, Line 1478: DAPC_PERI2_AO_SYS0_ATTR("EMI_MPU_APB_S", code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/81e99de1_987903ed PS1, Line 1478: DAPC_PERI2_AO_SYS0_ATTR("EMI_MPU_APB_S", please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/05872ff3_5272d58b PS1, Line 1478: DAPC_PERI2_AO_SYS0_ATTR("EMI_MPU_APB_S", please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/71b06870_0de5062b PS1, Line 1508: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/66ba2c37_345434eb PS1, Line 1517: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12), line over 96 characters
File src/soc/mediatek/mt8195/include/soc/devapc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/b1e4b333_09dc2561 PS1, Line 72: #define DAPC_PERM_ATTR_4(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/d6d59b64_d583b7e0 PS1, Line 77: #define DAPC_PERM_ATTR_8(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/e98651f9_9cb62935 PS1, Line 85: #define DAPC_PERM_ATTR_16(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/9ca26ec9_f3a483f3 PS1, Line 99: #define FORBIDDEN3 FORBIDDEN, FORBIDDEN, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/c97b7a8a_ebcd0c67 PS1, Line 100: #define FORBIDDEN7 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/ee801036_69e0540a PS1, Line 102: #define FORBIDDEN12 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/e5eb92b8_ef2a5c5f PS1, Line 105: #define FORBIDDEN13 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/b818c049_61e730cb PS1, Line 108: #define FORBIDDEN15 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/08d31495_613b69fa PS1, Line 127: #define DAPC_INFRA_AO_SYS0_ATTR(...) {{ DAPC_PERM_ATTR_16(__VA_ARGS__) }} space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/7595f5be_f65ae955 PS1, Line 128: #define DAPC_INFRA_AO_SYS1_ATTR(...) {{ DAPC_PERM_ATTR_4(__VA_ARGS__) }} space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/cc6072d5_5265de15 PS1, Line 129: #define DAPC_INFRA_AO_SYS2_ATTR(...) {{ DAPC_PERM_ATTR_4(__VA_ARGS__) }} space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/a54b57af_8526105a PS1, Line 130: #define DAPC_PERI_AO_SYS0_ATTR(...) {{ DAPC_PERM_ATTR_16(__VA_ARGS__) }} space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/aacee78b_d249e187 PS1, Line 131: #define DAPC_PERI_AO_SYS1_ATTR(...) {{ DAPC_PERM_ATTR_8(__VA_ARGS__) }} space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/57d946ff_4b6bb185 PS1, Line 132: #define DAPC_PERI2_AO_SYS0_ATTR(...) {{ DAPC_PERM_ATTR_16(__VA_ARGS__) }} space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125574): https://review.coreboot.org/c/coreboot/+/56764/comment/12393577_be068d00 PS1, Line 133: #define DAPC_PERI_PAR_AO_SYS0_ATTR(...) {{ DAPC_PERM_ATTR_16(__VA_ARGS__) }} space required after that close brace '}'
-
build bot (Jenkins) (Code Review)