Change in coreboot[master]: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F
Attention is currently required from: Christian Walter, Arthur Heymans, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37441 )
Change subject: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F ......................................................................
Patch Set 71:
(4 comments)
File Documentation/mainboard/supermicro/x11-lga1151v2-series/x11sch-f/x11sch-f.md:
https://review.coreboot.org/c/coreboot/+/37441/comment/665f7796_7f7d5cd5 PS64, Line 31: 0x235=03 and 0x13E=84
Then let's add that as comment
I remember reading somewhere that these offsets seem to be wrong. I haven't checked them myself.
File src/mainboard/supermicro/x11-lga1151v2-series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37441/comment/3e50202d_5ea0c480 PS67, Line 92: device pci 1f.2 off end # PMC
Haven't checked myself. I re-enabled it and doesn't seem to have any side-effects.
Done
File src/mainboard/supermicro/x11-lga1151v2-series/variants/x11sch-f/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37441/comment/4c2b8f19_97be1329 PS64, Line 6:
sry for the delay. it's not required, but makes matching acpi code easier, when gpe mapping matches.
Hmmm, not sure how to obtain the values and I haven't seen any side-effects of not specifying them. Anything to do?
File src/mainboard/supermicro/x11-lga1151v2-series/variants/x11sch-f/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37441/comment/84e295b0_2876857f PS67, Line 87: smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther" : "M.2-P_1" "SlotDataBusWidth4X" :
I have no clue.
Marking as resolved for now.
-
Angel Pons (Code Review)