Change in coreboot[master]: Doc/mb/lenovo/montevina_series: Use Makefile to generate IFD
Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39762 )
Change subject: Doc/mb/lenovo/montevina_series: Use Makefile to generate IFD ......................................................................
Doc/mb/lenovo/montevina_series: Use Makefile to generate IFD
util/bincfg's Makefile already has target that generates flash descriptor. Use it instea.
Change-Id: I1756514e1ab7b64de23a98314d8a32e9258e648c Signed-off-by: Evgeny Zinoviev me@ch1p.io --- M Documentation/mainboard/lenovo/montevina_series.md 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/39762/1
diff --git a/Documentation/mainboard/lenovo/montevina_series.md b/Documentation/mainboard/lenovo/montevina_series.md index 62e8796..45f2af4 100644 --- a/Documentation/mainboard/lenovo/montevina_series.md +++ b/Documentation/mainboard/lenovo/montevina_series.md @@ -103,9 +103,11 @@
Then create the flash descriptor: ```console -$ ./bincfg ifd-x200.spec ifd-x200.set ifd.bin +$ make gen-ifd-x200 ```
+It will be saved to the `flashregion_0_fd.bin` file. + #### Configuring coreboot
Now configure coreboot. You need to select correct chip size and specify paths @@ -118,7 +120,7 @@
Chipset ---> [*] Add Intel descriptor.bin file - # Note: if you used bincfg, specify path to generated util/bincfg/ifd.bin + # Note: if you used bincfg, specify path to generated util/bincfg/flashregion_0_fd.bin (/path/to/flashregion_0_flashdescriptor.bin) Path and filename of the descriptor.bin file
[*] Add gigabit ethernet configuration
Evgeny Zinoviev has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/39762 )
Change subject: Doc/mb/lenovo/montevina_series: Use Makefile to generate IFD ......................................................................
Doc/mb/lenovo/montevina_series: Use Makefile to generate IFD
util/bincfg's Makefile already has target that generates flash descriptor. Use it instead.
Change-Id: I1756514e1ab7b64de23a98314d8a32e9258e648c Signed-off-by: Evgeny Zinoviev me@ch1p.io --- M Documentation/mainboard/lenovo/montevina_series.md 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/39762/2
Attention is currently required from: Nico Huber, Evgeny Zinoviev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39762 )
Change subject: Doc/mb/lenovo/montevina_series: Use Makefile to generate IFD ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39762 )
Change subject: Doc/mb/lenovo/montevina_series: Use Makefile to generate IFD ......................................................................
Doc/mb/lenovo/montevina_series: Use Makefile to generate IFD
util/bincfg's Makefile already has target that generates flash descriptor. Use it instead.
Change-Id: I1756514e1ab7b64de23a98314d8a32e9258e648c Signed-off-by: Evgeny Zinoviev me@ch1p.io Reviewed-on: https://review.coreboot.org/c/coreboot/+/39762 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M Documentation/mainboard/lenovo/montevina_series.md 1 file changed, 4 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/Documentation/mainboard/lenovo/montevina_series.md b/Documentation/mainboard/lenovo/montevina_series.md index f3aca04..529fec6 100644 --- a/Documentation/mainboard/lenovo/montevina_series.md +++ b/Documentation/mainboard/lenovo/montevina_series.md @@ -112,9 +112,11 @@
Then create the flash descriptor: ```console -$ ./bincfg ifd-x200.spec ifd-x200.set ifd.bin +$ make gen-ifd-x200 ```
+It will be saved to the `flashregion_0_fd.bin` file. + #### Configuring coreboot
Now configure coreboot. You need to select correct chip size and specify paths @@ -127,7 +129,7 @@
Chipset ---> [*] Add Intel descriptor.bin file - # Note: if you used bincfg, specify path to generated util/bincfg/ifd.bin + # Note: if you used bincfg, specify path to generated util/bincfg/flashregion_0_fd.bin (/path/to/flashregion_0_flashdescriptor.bin) Path and filename of the descriptor.bin file
[*] Add gigabit ethernet configuration
-
Angel Pons (Code Review) -
Evgeny Zinoviev (Code Review)
-
Patrick Georgi (Code Review)