[XS] Change in coreboot[main]: nb/intel/sandybridge/raminit: Set SRT on Sandy Bridge

[Angel Pons (Code Review)]

Attention is currently required from: Patrick Rudolph, Paul Menzel.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79784?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: nb/intel/sandybridge/raminit: Set SRT on Sandy Bridge
......................................................................


Patch Set 3:

(1 comment)

File src/northbridge/intel/sandybridge/raminit_common.c:

https://review.coreboot.org/c/coreboot/+/79784/comment/82f25397_eb223d41 :
PS3, Line 784: if ((IS_IVY_CPU(ctrl->cpu) && ctrl->tCK >= TCK_1066MHZ) ||
             : 	    IS_SANDY_CPU(ctrl->cpu))
I believe the tCK check is to improve stability at high clock speeds. Sandy Bridge needs to be overclocked quite a bit to run at 1066 MHz (DDR3-2133), and it's likely it would benefit from SRT being disabled. So, we could simplify this check to `ctrl->tCK >= TCK_1066MHZ`.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79784?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id2773d3ae8c6c48193a23174086f62617335a7af
Gerrit-Change-Number: 79784
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Patrick Rudolph <[e-mail]>
Gerrit-Attention: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Thu, 11 Apr 2024 17:41:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment