Change in coreboot[master]: Doc/mb/lenovo/montevina_series: Describe GbE generating
Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39761 ) Change subject: Doc/mb/lenovo/montevina_series: Describe GbE generating ...................................................................... Doc/mb/lenovo/montevina_series: Describe GbE generating Instead of using the gbe region extracted from stock dump, one may want to generate the new one. util/bincfg can do that, but it's not documented anywhere yet. This patch describes how to do that along with changing the MAC address. Change-Id: I9318514b125b53f8ad76ad99755690ec6f681441 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- M Documentation/mainboard/lenovo/montevina_series.md 1 file changed, 30 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/39761/1 diff --git a/Documentation/mainboard/lenovo/montevina_series.md b/Documentation/mainboard/lenovo/montevina_series.md index 62e8796..39dee2f 100644 --- a/Documentation/mainboard/lenovo/montevina_series.md +++ b/Documentation/mainboard/lenovo/montevina_series.md @@ -33,6 +33,9 @@ $ ifdtool -x backup.rom ``` +Note that you can also [generate new GbE region](#generating-gbe-region) and use +it instead. + Now you need to patch the flash descriptor. You can either [modify the one from your backup with **ifdtool**](#modifying-flash-descriptor-using-ifdtool), or [generate a completely new one with **bincfg**](#creating-a-new-flash-descriptor-using-bincfg). @@ -122,6 +125,7 @@ (/path/to/flashregion_0_flashdescriptor.bin) Path and filename of the descriptor.bin file [*] Add gigabit ethernet configuration + # Note: if you used bincfg, specify path to generated util/bincfg/flashregion_3_gbe.bin (/path/to/flashregion_3_gbe.bin) Path to gigabit ethernet configuration ``` @@ -136,6 +140,32 @@ # flashrom -p YOUR_PROGRAMMER -w coreboot.rom --ifd -i bios ``` +## Generating GbE region + +GbE region contains configuration data for Intel integrated Gigabit Ethernet. +You can generate new GbE Region by using **bincfg**. To do that, go to +`util/bincfg`. + +It's good idea to set MAC address first, so open then `gbe-ich9m.set` file and +change values of `macaddress0` .. `macaddress5` fields. For example, if you want +to set MAC address to `00:01:02:03:04:05`: + +``` + "macaddress0" = 0x0, + "macaddress1" = 0x1, + "macaddress2" = 0x2, + "macaddress3" = 0x3, + "macaddress4" = 0x4, + "macaddress5" = 0x5 +``` + +Then run: +```console +$ make gen-gbe-ich9m +``` + +The new GbE region will be saved to `flashregion_3_gbe.bin`. + ## Flash layout The flash layouts of the OEM firmware are as follows: -- To view, visit https://review.coreboot.org/c/coreboot/+/39761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9318514b125b53f8ad76ad99755690ec6f681441 Gerrit-Change-Number: 39761 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-MessageType: newchange
Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/39761 to look at the new patch set (#2). Change subject: Doc/mb/lenovo/montevina_series: Describe GbE generating ...................................................................... Doc/mb/lenovo/montevina_series: Describe GbE generating Instead of using the gbe region extracted from stock dump, one may want to generate the new one. util/bincfg can do that, but it's not documented anywhere yet. This patch describes how to do that along with changing the MAC address. Change-Id: I9318514b125b53f8ad76ad99755690ec6f681441 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- M Documentation/mainboard/lenovo/montevina_series.md 1 file changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/39761/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/39761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9318514b125b53f8ad76ad99755690ec6f681441 Gerrit-Change-Number: 39761 Gerrit-PatchSet: 2 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/39761 to look at the new patch set (#3). Change subject: Doc/mb/lenovo/montevina_series: Describe GbE generating ...................................................................... Doc/mb/lenovo/montevina_series: Describe GbE generating Instead of using the gbe region extracted from stock dump, one may want to generate the new one. util/bincfg can do that, but it's not documented anywhere yet. This patch describes how to do that along with changing the MAC address. Change-Id: I9318514b125b53f8ad76ad99755690ec6f681441 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- M Documentation/mainboard/lenovo/montevina_series.md 1 file changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/39761/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/39761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9318514b125b53f8ad76ad99755690ec6f681441 Gerrit-Change-Number: 39761 Gerrit-PatchSet: 3 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/39761 to look at the new patch set (#4). Change subject: Doc/mb/lenovo/montevina_series: Describe GbE generation ...................................................................... Doc/mb/lenovo/montevina_series: Describe GbE generation Instead of using the gbe region extracted from stock dump, one may want to generate the new one. util/bincfg can do that, but it's not documented anywhere yet. This patch describes how to do that along with changing the MAC address. Change-Id: I9318514b125b53f8ad76ad99755690ec6f681441 Signed-off-by: Evgeny Zinoviev <me@ch1p.io> --- M Documentation/mainboard/lenovo/montevina_series.md 1 file changed, 34 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/39761/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/39761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9318514b125b53f8ad76ad99755690ec6f681441 Gerrit-Change-Number: 39761 Gerrit-PatchSet: 4 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: newpatchset
Swift Geek (Sebastian Grzywna) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39761 ) Change subject: Doc/mb/lenovo/montevina_series: Describe GbE generation ...................................................................... Patch Set 4: Code-Review+1 Following instructions on X200 yielded working image, with working NIC -- To view, visit https://review.coreboot.org/c/coreboot/+/39761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9318514b125b53f8ad76ad99755690ec6f681441 Gerrit-Change-Number: 39761 Gerrit-PatchSet: 4 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Sun, 10 May 2020 23:55:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39761 ) Change subject: Doc/mb/lenovo/montevina_series: Describe GbE generation ...................................................................... Patch Set 4: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/39761/4/Documentation/mainboard/len... File Documentation/mainboard/lenovo/montevina_series.md: https://review.coreboot.org/c/coreboot/+/39761/4/Documentation/mainboard/len... PS4, Line 160: ``` Indentation with four spaces is enough to mark it up as a code block. -- To view, visit https://review.coreboot.org/c/coreboot/+/39761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9318514b125b53f8ad76ad99755690ec6f681441 Gerrit-Change-Number: 39761 Gerrit-PatchSet: 4 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Mon, 11 May 2020 10:33:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39761 ) Change subject: Doc/mb/lenovo/montevina_series: Describe GbE generation ...................................................................... Patch Set 4: Code-Review+1 Please don't call it "generation". People are confused since ich9gen, because they didn't know that it had the "blobs" hardcoded. So they assume now that it's possible to mystically generate the data. `bincfg` simply transforms data from one format to another. -- To view, visit https://review.coreboot.org/c/coreboot/+/39761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9318514b125b53f8ad76ad99755690ec6f681441 Gerrit-Change-Number: 39761 Gerrit-PatchSet: 4 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 26 May 2020 12:13:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39761 ) Change subject: Doc/mb/lenovo/montevina_series: Describe GbE generation ...................................................................... Patch Set 4:
Patch Set 4: Code-Review+1
Please don't call it "generation". People are confused since ich9gen, because they didn't know that it had the "blobs" hardcoded. So they assume now that it's possible to mystically generate the data.
`bincfg` simply transforms data from one format to another.
Ok, what do you suggest to call it? "Creation with pre-defined data"? How about adding a link to the 82567LF/LM/V NVM Map datasheet? Maybe a separate page about bincfg could also help make things more clear. -- To view, visit https://review.coreboot.org/c/coreboot/+/39761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9318514b125b53f8ad76ad99755690ec6f681441 Gerrit-Change-Number: 39761 Gerrit-PatchSet: 4 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 26 May 2020 13:38:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39761 ) Change subject: Doc/mb/lenovo/montevina_series: Describe GbE generation ...................................................................... Patch Set 4:
Please don't call it "generation". People are confused since ich9gen, because they didn't know that it had the "blobs" hardcoded. So they assume now that it's possible to mystically generate the data.
`bincfg` simply transforms data from one format to another.
Ok, what do you suggest to call it? "Creation with pre-defined data"?
Um, maybe "Describe how to use in-tree data" or "Describe how to use checked-in data".
How about adding a link to the 82567LF/LM/V NVM Map datasheet?
Sounds good.
Maybe a separate page about bincfg could also help make things more clear.
Sure. -- To view, visit https://review.coreboot.org/c/coreboot/+/39761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9318514b125b53f8ad76ad99755690ec6f681441 Gerrit-Change-Number: 39761 Gerrit-PatchSet: 4 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 26 May 2020 13:47:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39761?usp=email ) Change subject: Doc/mb/lenovo/montevina_series: Describe GbE generation ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/39761?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9318514b125b53f8ad76ad99755690ec6f681441 Gerrit-Change-Number: 39761 Gerrit-PatchSet: 4 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: abandon
participants (5)
-
Evgeny Zinoviev (Code Review) -
Nico Huber (Code Review)
-
Paul Menzel (Code Review)
-
Stefan Reinauer (Code Review)
-
Swift Geek (Sebastian Grzywna) (Code Review)