Change in coreboot[master]: soc/intel/tigerlake: Add function to dump ME firmware status information
Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39127 )
Change subject: soc/intel/tigerlake: Add function to dump ME firmware status information ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39127/8/src/soc/intel/tigerlake/Mak... File src/soc/intel/tigerlake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39127/8/src/soc/intel/tigerlake/Mak... PS8, Line 52: ramstage-y += me.c
You have to do this in the previous patch in the train
Done
https://review.coreboot.org/c/coreboot/+/39127/8/src/soc/intel/tigerlake/me.... File src/soc/intel/tigerlake/me.c:
https://review.coreboot.org/c/coreboot/+/39127/8/src/soc/intel/tigerlake/me.... PS8, Line 144: spi_protection_mode
This bit should be cleared to indicate that SPI protection is in place? in that case the name signif […]
It is to keep the naming inline with ME document.
https://review.coreboot.org/c/coreboot/+/39127/8/src/soc/intel/tigerlake/me.... PS8, Line 145: "NO" : "YES")
Is it correct? […]
When these two criteria are satisfied, it means end of manufacturing. It is no more in manufacturing mode (Manufacturing mode = “NO”).
-
Krishna P Bhat D (Code Review)