Change in coreboot[master]: soc/mediatek/mt8186: Add a stub implementation of the MT8186 SoC - coreboot-gerrit

2 Nov 2021


      Attention is currently required from: Paul Menzel, Yu-Ping Wu, Felix Held.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58640 )
Change subject: soc/mediatek/mt8186: Add a stub implementation of the MT8186 SoC
......................................................................
Patch Set 5:
(1 comment)
File src/soc/mediatek/mt8186/include/soc/timer.h:
https://review.coreboot.org/c/coreboot/+/58640/comment/24b8ace3_588f45a4 
PS3, Line 9: TIE_0_EN = 1 << 3,
           : 	COMP_15_EN = 1 << 10,
           : 	COMP_20_EN = 1 << 11,
           : 	COMP_25_EN = 1 << 12,
...
I think I would move these to v2 on upcoming patches. […]
I have done on https://review.coreboot.org/c/coreboot/+/58829
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58640
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I579f79c15f4bf5e1daf6b35c70cfd00a985a0b81
Gerrit-Change-Number: 58640
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 02 Nov 2021 02:51:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rex-BC Chen rex-bc.chen@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com
Gerrit-MessageType: comment