Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Maximilian Brune.
Paul Menzel has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84574?usp=email )
Change subject: soc/amd/glinda-phoenix: Update pci int defs
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Thank you for doing this.
Commit Message:
https://review.coreboot.org/c/coreboot/+/84574/comment/068a85d0_3e523571?usp... :
PS2, Line 11:
It’d still be nice, if you summarized the change. In this case two macros seem to be updated?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84574?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I64f685e507e1cd5ee90e1b18526b9d59ed4c1b34
Gerrit-Change-Number: 84574
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 28 Sep 2024 08:04:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No