Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37287 )
Change subject: mb/lenovo/t400/Makefile: Build gpio w/o subdir makefiles ......................................................................
mb/lenovo/t400/Makefile: Build gpio w/o subdir makefiles
Change-Id: Ia2e889fe72d746b71d92026e358c7471f56b381f Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/t400/Makefile.inc D src/mainboard/lenovo/t400/variants/r500/Makefile.inc D src/mainboard/lenovo/t400/variants/t400/Makefile.inc 3 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/37287/1
diff --git a/src/mainboard/lenovo/t400/Makefile.inc b/src/mainboard/lenovo/t400/Makefile.inc index b3ca78d..e4e6a1f 100644 --- a/src/mainboard/lenovo/t400/Makefile.inc +++ b/src/mainboard/lenovo/t400/Makefile.inc @@ -16,7 +16,7 @@ bootblock-y += bootblock.c bootblock-y += dock.c
-subdirs-y += variants/$(VARIANT_DIR)/ +romstage-y += variants/$(VARIANT_DIR)/gpio.c
ramstage-y += dock.c ramstage-y += cstates.c diff --git a/src/mainboard/lenovo/t400/variants/r500/Makefile.inc b/src/mainboard/lenovo/t400/variants/r500/Makefile.inc deleted file mode 100644 index 3dae61e..0000000 --- a/src/mainboard/lenovo/t400/variants/r500/Makefile.inc +++ /dev/null @@ -1 +0,0 @@ -romstage-y += gpio.c diff --git a/src/mainboard/lenovo/t400/variants/t400/Makefile.inc b/src/mainboard/lenovo/t400/variants/t400/Makefile.inc deleted file mode 100644 index 3dae61e..0000000 --- a/src/mainboard/lenovo/t400/variants/t400/Makefile.inc +++ /dev/null @@ -1 +0,0 @@ -romstage-y += gpio.c
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37287 )
Change subject: mb/lenovo/t400/Makefile: Build gpio w/o subdir makefiles ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37287 )
Change subject: mb/lenovo/t400/Makefile: Build gpio w/o subdir makefiles ......................................................................
mb/lenovo/t400/Makefile: Build gpio w/o subdir makefiles
Change-Id: Ia2e889fe72d746b71d92026e358c7471f56b381f Signed-off-by: Peter Lemenkov lemenkov@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37287 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/lenovo/t400/Makefile.inc D src/mainboard/lenovo/t400/variants/r500/Makefile.inc D src/mainboard/lenovo/t400/variants/t400/Makefile.inc 3 files changed, 1 insertion(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/lenovo/t400/Makefile.inc b/src/mainboard/lenovo/t400/Makefile.inc index b3ca78d..e4e6a1f 100644 --- a/src/mainboard/lenovo/t400/Makefile.inc +++ b/src/mainboard/lenovo/t400/Makefile.inc @@ -16,7 +16,7 @@ bootblock-y += bootblock.c bootblock-y += dock.c
-subdirs-y += variants/$(VARIANT_DIR)/ +romstage-y += variants/$(VARIANT_DIR)/gpio.c
ramstage-y += dock.c ramstage-y += cstates.c diff --git a/src/mainboard/lenovo/t400/variants/r500/Makefile.inc b/src/mainboard/lenovo/t400/variants/r500/Makefile.inc deleted file mode 100644 index 3dae61e..0000000 --- a/src/mainboard/lenovo/t400/variants/r500/Makefile.inc +++ /dev/null @@ -1 +0,0 @@ -romstage-y += gpio.c diff --git a/src/mainboard/lenovo/t400/variants/t400/Makefile.inc b/src/mainboard/lenovo/t400/variants/t400/Makefile.inc deleted file mode 100644 index 3dae61e..0000000 --- a/src/mainboard/lenovo/t400/variants/t400/Makefile.inc +++ /dev/null @@ -1 +0,0 @@ -romstage-y += gpio.c
-
Nico Huber (Code Review) -
Patrick Georgi (Code Review)
-
Peter Lemenkov (Code Review)