Attention is currently required from: Kevin Keijzer, Felix Singer, Arthur Heymans, Nicholas Chin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73450 )
Change subject: mb/asrock/b75-pro3-m: Fix S3 resume and hardware monitoring
......................................................................
Patch Set 1: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73450/comment/17dd29ae_8fcabd5a
PS1, Line 7: b75-pro3-m
nit: b75pro3-m
https://review.coreboot.org/c/coreboot/+/73450/comment/2ff73b57_17cb2ced
PS1, Line 10: cb:20227
Please reference the commit hash, i.e.:
commit 928c6c6336f2f04a7bd2d489ac9901aa0d7dfa2a (mainboard/asrock: add ASRock B75 Pro3-M)
You can shorten the commit hash to 12 characters or so, too:
commit 928c6c6336f2 (mainboard/asrock: add ASRock B75 Pro3-M)
Patchset:
PS1:
Looks good, just some small things about the commit message
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73450
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e504fe4b60da1d7b9830bea5029101bb8cebcb5
Gerrit-Change-Number: 73450
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Keijzer
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Fabian Groffen
grobian@gentoo.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Kevin Keijzer
kevin@quietlife.nl
Gerrit-Reviewer: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kevin Keijzer
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Kevin Keijzer
kevin@quietlife.nl
Gerrit-Comment-Date: Sat, 04 Mar 2023 11:45:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment