Attention is currently required from: Jeff Daly, Paul Menzel, Stefan Reinauer, Kyösti Mälkki. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60736 )
Change subject: util/ifdtool: Add additional regions for platforms that support them ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/60736/comment/f68c67dd_276042f2 PS4, Line 43: Expansion1 Are there more "Device Expansion" regions? If not, I'd remove the `1` from here.
https://review.coreboot.org/c/coreboot/+/60736/comment/76d28853_85ffb9a5 PS4, Line 43: SI_DEV_EXP1 These are the names for the corresponding FMAP (.fmd files in the coreboot tree) regions. Apollo and Gemini Lake also have this `Device Expansion` region. Looks like some Apollo Lake boards in the tree have a FMAP layout that use the `SI_DEVICEEXT` name for this region, so I'd use the same name here for consistency.