[S] Change in coreboot[main]: mb/google/rex/var/rex0: Toggle NVMe PWR pin to reset SSD - coreboot-gerrit

31 Oct 2023


      Attention is currently required from: Eran Mitrani, Ivy Jian, Jamie Ryu, Kapil Porwal, Paul Menzel, Tarun, Tarun Tuli, Wonkyu Kim.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71221?usp=email )
Change subject: mb/google/rex/var/rex0: Toggle NVMe PWR pin to reset SSD
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File src/mainboard/google/rex/variants/rex0/gpio.c:
https://review.coreboot.org/c/coreboot/+/71221/comment/633d5c92_53b1acea :
PS1, Line 42: DEEP
...
how about configuring this as `PWROK`?
DEEP looks more optimized.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/71221?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f34e3f49e7fc388198ff85c8e119cb3f242a60e
Gerrit-Change-Number: 71221
Gerrit-PatchSet: 4
Gerrit-Owner: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Reviewer: Eran Mitrani mitrani@google.com
Gerrit-Reviewer: Ivy Jian ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Jamie Ryu jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun tstuli@gmail.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Cliff Huang cliff.huang@intel.com
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Jamie Ryu jamie.m.ryu@intel.com
Gerrit-Attention: Eran Mitrani mitrani@google.com
Gerrit-Attention: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Ivy Jian ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Tarun tstuli@gmail.com
Gerrit-Comment-Date: Tue, 31 Oct 2023 04:24:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Gerrit-MessageType: comment