Attention is currently required from: Maximilian Brune.
Marshall Dawson has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84436?usp=email )
Change subject: mb/amd/birman_plus/devicetree_glinda.cb: Update USB ......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84436/comment/0407f28d_c1fc48fc?usp... : PS4, Line 9: Signed-off-by: Satya SreenivasL satya.sreenivasl@amd.com : Change-Id: I0603f5da689b6738ea54305a665b150121bc520c : Reviewed-by: Anand Vaikar a.vaikar2021@gmail.com : Reviewed-by: Ritul Guru ritul.bits@gmail.com : Tested-by: Satya Sreenivas L Satya.SreenivasL@amd.com : Consider prepending these with "Original-" to keep the git history clean?
File src/mainboard/amd/birman_plus/devicetree_glinda.cb:
https://review.coreboot.org/c/coreboot/+/84436/comment/9f695441_336c750d?usp... : PS4, Line 140: .txvreftune = 0x6, 3? I'm comparing against AmdCpmPkg/Addendum/Oem/BirmanPlus/AmdCpmPkg.inc.dsc
https://review.coreboot.org/c/coreboot/+/84436/comment/3a81a6ed_8abb2035?usp... : PS4, Line 154: .txvreftune = 0x6 3?