Attention is currently required from: Jason Glenesk, Furquan Shaikh, Marshall Dawson, Julius Werner, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56491 )
Change subject: lib/cbfs: Add cbfs_preload()
......................................................................
Patch Set 12:
(2 comments)
File src/lib/Kconfig:
https://review.coreboot.org/c/coreboot/+/56491/comment/d8a3de8b_566350f1
PS7, Line 108: config CBFS_PRELOAD
Well, it shouldn't really make a practical difference if the controller uses PIO, it'll just not giv […]
Right, it doesn't cause an actual problem booting. It just means that the async transactions can turn into sync transactions unexpectedly and thus penalizing a random section of code.
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/56491/comment/777d4c4e_a0b6a309
PS11, Line 511: cbfs_unmap(rdev_mmap_full(&rdev));
Rather than duplicating everything in the error path I think it would be better to just merge them, […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56491
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I879fc1316f97417a4b82483d353abdbd02b98a31
Gerrit-Change-Number: 56491
Gerrit-PatchSet: 12
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 02 Nov 2021 03:36:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment