Kyösti Mälkki (kyosti.malkki@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3485
-gerrit
commit 109783ceb0060da0f54825fba498c80fdf56b7cc Author: Kyösti Mälkki kyosti.malkki@gmail.com Date: Sun Jun 16 17:30:29 2013 +0300
AMD boards: Clean use of Kconfig options
The chip component is unconditionally selected for the mainboard so these uses are superfluous.
Change-Id: I84b053ab47f7b1f68e88d968cf305e24bc95f4da Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- src/mainboard/amd/dinar/Kconfig | 1 - src/mainboard/amd/torpedo/Kconfig | 1 - src/mainboard/supermicro/h8qgi/Makefile.inc | 12 ++++++------ src/mainboard/supermicro/h8scm/Makefile.inc | 12 ++++++------ src/mainboard/tyan/s8226/Makefile.inc | 12 ++++++------ 5 files changed, 18 insertions(+), 20 deletions(-)
diff --git a/src/mainboard/amd/dinar/Kconfig b/src/mainboard/amd/dinar/Kconfig index 9edbe7a..48c1e74 100644 --- a/src/mainboard/amd/dinar/Kconfig +++ b/src/mainboard/amd/dinar/Kconfig @@ -146,7 +146,6 @@ config CONSOLE_POST config SATA_CONTROLLER_MODE hex default 0x0 - depends on SOUTHBRIDGE_AMD_CIMX_SB700
config ONBOARD_LAN bool diff --git a/src/mainboard/amd/torpedo/Kconfig b/src/mainboard/amd/torpedo/Kconfig index ac42a4f..2c70143 100644 --- a/src/mainboard/amd/torpedo/Kconfig +++ b/src/mainboard/amd/torpedo/Kconfig @@ -168,7 +168,6 @@ config CONSOLE_POST config SATA_CONTROLLER_MODE hex default 0x0 - depends on SOUTHBRIDGE_AMD_CIMX_SB900
config ONBOARD_LAN bool diff --git a/src/mainboard/supermicro/h8qgi/Makefile.inc b/src/mainboard/supermicro/h8qgi/Makefile.inc index cd56c47..451e013 100644 --- a/src/mainboard/supermicro/h8qgi/Makefile.inc +++ b/src/mainboard/supermicro/h8qgi/Makefile.inc @@ -17,17 +17,17 @@ # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA #
-romstage-$(CONFIG_NORTHBRIDGE_AMD_CIMX_RD890) += rd890_cfg.c -romstage-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB700) += sb700_cfg.c -romstage-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB700) += reset.c +romstage-y += rd890_cfg.c +romstage-y += sb700_cfg.c +romstage-y += reset.c romstage-y += buildOpts.c romstage-y += agesawrapper.c romstage-y += BiosCallOuts.c romstage-y += platform_oem.c
-ramstage-$(CONFIG_NORTHBRIDGE_AMD_CIMX_RD890) += rd890_cfg.c -ramstage-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB700) += sb700_cfg.c -ramstage-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB700) += reset.c +ramstage-y += rd890_cfg.c +ramstage-y += sb700_cfg.c +ramstage-y += reset.c ramstage-y += buildOpts.c ramstage-y += agesawrapper.c ramstage-y += BiosCallOuts.c diff --git a/src/mainboard/supermicro/h8scm/Makefile.inc b/src/mainboard/supermicro/h8scm/Makefile.inc index cd56c47..451e013 100644 --- a/src/mainboard/supermicro/h8scm/Makefile.inc +++ b/src/mainboard/supermicro/h8scm/Makefile.inc @@ -17,17 +17,17 @@ # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA #
-romstage-$(CONFIG_NORTHBRIDGE_AMD_CIMX_RD890) += rd890_cfg.c -romstage-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB700) += sb700_cfg.c -romstage-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB700) += reset.c +romstage-y += rd890_cfg.c +romstage-y += sb700_cfg.c +romstage-y += reset.c romstage-y += buildOpts.c romstage-y += agesawrapper.c romstage-y += BiosCallOuts.c romstage-y += platform_oem.c
-ramstage-$(CONFIG_NORTHBRIDGE_AMD_CIMX_RD890) += rd890_cfg.c -ramstage-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB700) += sb700_cfg.c -ramstage-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB700) += reset.c +ramstage-y += rd890_cfg.c +ramstage-y += sb700_cfg.c +ramstage-y += reset.c ramstage-y += buildOpts.c ramstage-y += agesawrapper.c ramstage-y += BiosCallOuts.c diff --git a/src/mainboard/tyan/s8226/Makefile.inc b/src/mainboard/tyan/s8226/Makefile.inc index cd56c47..451e013 100644 --- a/src/mainboard/tyan/s8226/Makefile.inc +++ b/src/mainboard/tyan/s8226/Makefile.inc @@ -17,17 +17,17 @@ # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA #
-romstage-$(CONFIG_NORTHBRIDGE_AMD_CIMX_RD890) += rd890_cfg.c -romstage-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB700) += sb700_cfg.c -romstage-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB700) += reset.c +romstage-y += rd890_cfg.c +romstage-y += sb700_cfg.c +romstage-y += reset.c romstage-y += buildOpts.c romstage-y += agesawrapper.c romstage-y += BiosCallOuts.c romstage-y += platform_oem.c
-ramstage-$(CONFIG_NORTHBRIDGE_AMD_CIMX_RD890) += rd890_cfg.c -ramstage-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB700) += sb700_cfg.c -ramstage-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB700) += reset.c +ramstage-y += rd890_cfg.c +ramstage-y += sb700_cfg.c +ramstage-y += reset.c ramstage-y += buildOpts.c ramstage-y += agesawrapper.c ramstage-y += BiosCallOuts.c
-
Kyösti Mälkki