Change in coreboot[master]: mb/google/guybrush: Unmask eSPI keyboard IRQ - coreboot-gerrit

6 Apr 2021


      Attention is currently required from: Martin Roth, Rob Barnes.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52143 )
Change subject: mb/google/guybrush: Unmask eSPI keyboard IRQ
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/guybrush/mainboard.c:
https://review.coreboot.org/c/coreboot/+/52143/comment/af266e61_949859a0 
PS1, Line 118: 	/* Unmask eSPI IRQ 1 and 12 */
...
nit: It'd be helpful to comment what these IRQS map to.
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52143
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97b7382eac28aae2cc82f430c58cf8066b9701e1
Gerrit-Change-Number: 52143
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Comment-Date: Tue, 06 Apr 2021 21:58:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes robbarnes@google.com
Gerrit-MessageType: comment