[L] Change in coreboot[master]: soc/intel/common, alderlake: provide a list of D-states to enter LPM
Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal.
Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70166 )
Change subject: soc/intel/common, alderlake: provide a list of D-states to enter LPM ......................................................................
Patch Set 8:
(6 comments)
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/70166/comment/e26e9a23_66ae2402 PS7, Line 168: struct min_sleep_state min_pci_sleep_states[] = {
how about marking this structure as static ?
Done
https://review.coreboot.org/c/coreboot/+/70166/comment/1bfecb0e_9d8e036c PS7, Line 233: soc_lpi_get_constraints
can't we call `acpi_generate_lpi_constraint_table()` directly from pep. […]
Done
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/70166/comment/6ad4ad05_e18ad8ca PS7, Line 30: = 0
same
Done
https://review.coreboot.org/c/coreboot/+/70166/comment/8d909a54_4f8226de PS7, Line 31: };
please one blank line
Done
https://review.coreboot.org/c/coreboot/+/70166/comment/2476dd7b_585870da PS7, Line 455: ar
`ar` is like array ? […]
Done
https://review.coreboot.org/c/coreboot/+/70166/comment/37720101_c2dcf91c PS7, Line 495: return;
I think you need to create a default entry here like what `soc_lpi_get_constraints()` does in `src/s […]
Done
-
Eran Mitrani (Code Review)