Attention is currently required from: Eran Mitrani, Jakub Czapiga, Paul Menzel, Pratikkumar V Prajapati, Subrata Banik, Sumeet R Pawnikar, Tarun, Tarun Tuli, Tracy Wu.
Hello Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, Tarun Tuli, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76333?usp=email
to look at the new patch set (#18).
The following approvals got outdated and were removed:
Code-Review+1 by Subrata Banik, Verified+1 by build bot (Jenkins)
Change subject: soc/intel/meteorlake: Validate CPU crashlog discovery table and records
......................................................................
soc/intel/meteorlake: Validate CPU crashlog discovery table and records
CPU crashlog discovery table and crashlog record is considered
invalid if first 32bits of the table is either 0x0 (no crashlog)
or 0xdeadbeef (invalid crashlog).
Crashlog record is considered consumed if bit 31 is set. So in this
case stop processing the subsequent records.
BUG=b:289600699
TEST=Able to build and verified invalid records are skipped on google/rex.
Change-Id: Ia81bd293a533217425e44473ae85b2115c85faf6
Signed-off-by: Pratikkumar Prajapati pratikkumar.v.prajapati@intel.com
---
M src/soc/intel/meteorlake/crashlog.c
1 file changed, 24 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/76333/18
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76333?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia81bd293a533217425e44473ae85b2115c85faf6
Gerrit-Change-Number: 76333
Gerrit-PatchSet: 18
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Pratikkumar Prajapati
pratikkumar.v.prajapati@intel.corp-partner.google.com
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-CC: Tracy Wu
tracy.wu@intel.corp-partner.google.com
Gerrit-Attention: Tracy Wu
tracy.wu@intel.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-MessageType: newpatchset