Xi Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47696 )
Change subject: soc/mediatek/mt8192: Add samsung sdparam config ......................................................................
soc/mediatek/mt8192: Add samsung sdparam config
KMDP6001DA-B425-4GB KMDV6001DA-B620-4GB
Signed-off-by: Xi Chen xixi.chen@mediatek.com Change-Id: Ib9448e1ed93a41f3c7f48add8817d07dcf06c40a --- M src/mainboard/google/asurada/sdram_configs.c M src/mainboard/google/asurada/sdram_params/Makefile.inc A src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c A src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c 4 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/47696/1
diff --git a/src/mainboard/google/asurada/sdram_configs.c b/src/mainboard/google/asurada/sdram_configs.c index 9efcb32..acefada 100644 --- a/src/mainboard/google/asurada/sdram_configs.c +++ b/src/mainboard/google/asurada/sdram_configs.c @@ -8,6 +8,8 @@ static const char *const sdram_configs[] = { [0] = "sdram-lpddr4x-MT29VZZZBD9DQKPR-046-6GB", [1] = "sdram-lpddr4x-MT29VZZZAD8GQFSL-046-4GB", + [2] = "sdram-lpddr4x-KMDP6001DA-B425-4GB", + [3] = "sdram-lpddr4x-KMDV6001DA-B620-4GB", };
static struct sdram_info params; diff --git a/src/mainboard/google/asurada/sdram_params/Makefile.inc b/src/mainboard/google/asurada/sdram_params/Makefile.inc index acc8b58..7a591f4 100644 --- a/src/mainboard/google/asurada/sdram_params/Makefile.inc +++ b/src/mainboard/google/asurada/sdram_params/Makefile.inc @@ -1,6 +1,8 @@ sdram-params := sdram-params += sdram-lpddr4x-MT29VZZZBD9DQKPR-046-6GB sdram-params += sdram-lpddr4x-MT29VZZZAD8GQFSL-046-4GB +sdram-params += sdram-lpddr4x-KMDP6001DA-B425-4GB +sdram-params += sdram-lpddr4x-KMDV6001DA-B620-4GB
$(foreach params,$(sdram-params), \ $(eval cbfs-files-y += $(params)) \ diff --git a/src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c b/src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c new file mode 100644 index 0000000..aa9c084 --- /dev/null +++ b/src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c @@ -0,0 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <soc/dramc_param.h> + +struct sdram_info params = { + .ddr_geometry = DDR_TYPE_2CH_2RK_4GB_2_2, +}; diff --git a/src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c b/src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c new file mode 100644 index 0000000..aa9c084 --- /dev/null +++ b/src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c @@ -0,0 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <soc/dramc_param.h> + +struct sdram_info params = { + .ddr_geometry = DDR_TYPE_2CH_2RK_4GB_2_2, +};
Yidi Lin has uploaded a new patch set (#3) to the change originally created by Xi Chen. ( https://review.coreboot.org/c/coreboot/+/47696 )
Change subject: soc/mediatek/mt8192: Add samsung sdparam config ......................................................................
soc/mediatek/mt8192: Add samsung sdparam config
KMDP6001DA-B425-4GB KMDV6001DA-B620-4GB
Signed-off-by: Xi Chen xixi.chen@mediatek.com Change-Id: Ib9448e1ed93a41f3c7f48add8817d07dcf06c40a --- M src/mainboard/google/asurada/sdram_configs.c M src/mainboard/google/asurada/sdram_params/Makefile.inc A src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c A src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c 4 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/47696/3
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47696 )
Change subject: soc/mediatek/mt8192: Add samsung sdparam config ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47696/6/src/mainboard/google/asurad... File src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c:
https://review.coreboot.org/c/coreboot/+/47696/6/src/mainboard/google/asurad... PS6, Line 6: DDR_TYPE_2CH_2RK_4GB_2_2 Hung-te and Yu-ping
We encountered a bug that the blob size is zero when .ddr_geometry is set to 0 due to optimization. (The value of DDR_TYPE_2CH_2RK_4GB_2_2 is 0)
sdram-lpddr4x-MT29VZZZBD9DQKPR-046-6GB 0x5ac80 struct 4 none sdram-lpddr4x-MT29VZZZAD8GQFSL-046-4GB 0x5ad00 struct 4 none sdram-lpddr4x-KMDP6001DA-B425-4GB 0x5ad80 struct 0 none sdram-lpddr4x-KMDV6001DA-B620-4GB 0x5ae00 struct 0 none
We had tried the enum value other than zero and the blob could be generated normally.
Could you give us some advices for solving this ?
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47696 )
Change subject: soc/mediatek/mt8192: Add samsung sdparam config ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47696/6/src/mainboard/google/asurad... File src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c:
https://review.coreboot.org/c/coreboot/+/47696/6/src/mainboard/google/asurad... PS6, Line 6: DDR_TYPE_2CH_2RK_4GB_2_2
Hung-te and Yu-ping […]
I uploaded CB:47903 as a fixing patch. Please test if it works as expected with the patch.
Yidi, please DO NOT modify/rebase CB:47903. You could include it in Asurada ToT, but please use a different Change-Id (so that my CL won't get modified).
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47696 )
Change subject: soc/mediatek/mt8192: Add samsung sdparam config ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47696/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47696/7//COMMIT_MSG@9 PS7, Line 9: KMDP6001DA-B425-4GB : KMDV6001DA-B620-4GB Use list:
- KMDP6001DA... - KMDP6001DA...
Yidi Lin has uploaded a new patch set (#14) to the change originally created by Xi Chen. ( https://review.coreboot.org/c/coreboot/+/47696 )
Change subject: soc/mediatek/mt8192: Add samsung sdparam config ......................................................................
soc/mediatek/mt8192: Add samsung sdparam config
KMDP6001DA-B425-4GB KMDV6001DA-B620-4GB
Signed-off-by: Xi Chen xixi.chen@mediatek.com Change-Id: Ib9448e1ed93a41f3c7f48add8817d07dcf06c40a --- M src/mainboard/google/asurada/sdram_configs.c M src/mainboard/google/asurada/sdram_params/Makefile.inc A src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c A src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c 4 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/47696/14
Yidi Lin has uploaded a new patch set (#16) to the change originally created by Xi Chen. ( https://review.coreboot.org/c/coreboot/+/47696 )
Change subject: soc/mediatek/mt8192: Add samsung sdparam config ......................................................................
soc/mediatek/mt8192: Add samsung sdparam config
KMDP6001DA-B425-4GB KMDV6001DA-B620-4GB
Signed-off-by: Xi Chen xixi.chen@mediatek.com Change-Id: Ib9448e1ed93a41f3c7f48add8817d07dcf06c40a --- M src/mainboard/google/asurada/sdram_configs.c M src/mainboard/google/asurada/sdram_params/Makefile.inc A src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDP6001DA-B425-4GB.c A src/mainboard/google/asurada/sdram_params/sdram-lpddr4x-KMDV6001DA-B620-4GB.c 4 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/47696/16
Xi Chen has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47696 )
Change subject: soc/mediatek/mt8192: Add samsung sdparam config ......................................................................
Abandoned
-
Xi Chen (Code Review) -
Yidi Lin (Code Review)
-
Yu-Ping Wu (Code Review)