Change in ...coreboot[master]: soc/intel/skylake: Remove redundent PM emulation time macros
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31610
Change subject: soc/intel/skylake: Remove redundent PM emulation time macros ......................................................................
soc/intel/skylake: Remove redundent PM emulation time macros
This patch removes duplicate pm timer emulation macros from soc directory and make use from common code msr.h
Change-Id: I6ec347e7464f785862e855817ec8308e3d207bb1 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/skylake/include/soc/msr.h 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/31610/1
diff --git a/src/soc/intel/skylake/include/soc/msr.h b/src/soc/intel/skylake/include/soc/msr.h index 6da9325..bd0942a 100644 --- a/src/soc/intel/skylake/include/soc/msr.h +++ b/src/soc/intel/skylake/include/soc/msr.h @@ -20,10 +20,6 @@ #include <intelblocks/msr.h>
#define MSR_PIC_MSG_CONTROL 0x2e -#define MSR_EMULATE_PM_TIMER 0x121 -#define EMULATE_PM_TMR_EN (1 << 16) -#define EMULATE_DELAY_OFFSET_VALUE 20 -#define EMULATE_DELAY_VALUE 0x13 #define MSR_LT_LOCK_MEMORY 0x2e7 #define MSR_UNCORE_PRMRR_PHYS_BASE 0x2f4 #define MSR_UNCORE_PRMRR_PHYS_MASK 0x2f5
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31610 )
Change subject: soc/intel/skylake: Remove redundent PM emulation time macros ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/31610/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31610/1//COMMIT_MSG@7 PS1, Line 7: time timer
https://review.coreboot.org/#/c/31610/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/skylake: Remove redundent PM emulation time macros redundant
https://review.coreboot.org/#/c/31610/1//COMMIT_MSG@10 PS1, Line 10: make makes
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31610 )
Change subject: soc/intel/skylake: Remove redundent PM emulation time macros ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/31610/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31610/1//COMMIT_MSG@7 PS1, Line 7: time
timer
Done
https://review.coreboot.org/#/c/31610/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/skylake: Remove redundent PM emulation time macros
redundant
Done
https://review.coreboot.org/#/c/31610/1//COMMIT_MSG@10 PS1, Line 10: make
makes
Done
Hello Aaron Durbin, Patrick Rudolph, Aamir Bohra, Rizwan Qureshi, Duncan Laurie, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31610
to look at the new patch set (#2).
Change subject: soc/intel/skylake: Remove redundant PM emulation timer macros ......................................................................
soc/intel/skylake: Remove redundant PM emulation timer macros
This patch removes duplicate pm timer emulation macros from soc directory and makes use from common code msr.h
Change-Id: I6ec347e7464f785862e855817ec8308e3d207bb1 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/skylake/include/soc/msr.h 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/31610/2
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31610 )
Change subject: soc/intel/skylake: Remove redundant PM emulation timer macros ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31610 )
Change subject: soc/intel/skylake: Remove redundant PM emulation timer macros ......................................................................
Patch Set 2: Code-Review+2
Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31610 )
Change subject: soc/intel/skylake: Remove redundant PM emulation timer macros ......................................................................
soc/intel/skylake: Remove redundant PM emulation timer macros
This patch removes duplicate pm timer emulation macros from soc directory and makes use from common code msr.h
Change-Id: I6ec347e7464f785862e855817ec8308e3d207bb1 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/31610 Reviewed-by: Aamir Bohra aamir.bohra@intel.com Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/skylake/include/soc/msr.h 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Aamir Bohra: Looks good to me, approved
diff --git a/src/soc/intel/skylake/include/soc/msr.h b/src/soc/intel/skylake/include/soc/msr.h index 6da9325..bd0942a 100644 --- a/src/soc/intel/skylake/include/soc/msr.h +++ b/src/soc/intel/skylake/include/soc/msr.h @@ -20,10 +20,6 @@ #include <intelblocks/msr.h>
#define MSR_PIC_MSG_CONTROL 0x2e -#define MSR_EMULATE_PM_TIMER 0x121 -#define EMULATE_PM_TMR_EN (1 << 16) -#define EMULATE_DELAY_OFFSET_VALUE 20 -#define EMULATE_DELAY_VALUE 0x13 #define MSR_LT_LOCK_MEMORY 0x2e7 #define MSR_UNCORE_PRMRR_PHYS_BASE 0x2f4 #define MSR_UNCORE_PRMRR_PHYS_MASK 0x2f5
-
Aamir Bohra (Code Review) -
Furquan Shaikh (Code Review)
-
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)