[S] Change in coreboot[master]: src/lib: Include LZMA in romstage for FSP-M - coreboot-gerrit

8 Jan 2023


      Attention is currently required from: Martin Roth.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71674 )
Change subject: src/lib: Include LZMA in romstage for FSP-M
......................................................................
Patch Set 1:
(1 comment)
File src/lib/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/71674/comment/66a31787_81b1b740 
PS1, Line 98: ifneq ($(CONFIG_COMPRESS_RAMSTAGE_LZMA)$(CONFIG_FSP_COMPRESS_FSP_M_LZMA),)
...
Could also just always compile it in and let the linker garbage collection take care of it.
It's not a bad point, and maybe as a part of future cleanup we can go through and remove the extra conditions.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/71674
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id52d25a13420f05db8b2b563de0448f9d44638e0
Gerrit-Change-Number: 71674
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Sun, 08 Jan 2023 01:21:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment