Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41106 )
Change subject: arch/x86: handle ramstage.c by default in Make
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41106/7/src/arch/x86/Makefile.inc
File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41106/7/src/arch/x86/Makefile.inc@2...
PS7, Line 272: ramstage-srcs += $(wildcard src/mainboard/$(MAINBOARDDIR)/ramstage.c)
Are the two above intentionally kept under arch/x86?
no idea, I added bootblock.c and ramstage.c here because mainboard.c and some others were here already. Probably it'd be a good idea to move them all to some generic location so we don't have to repeat that for multiple platforms. /Makefile.inc maybe?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41106
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibfc7d8eb97b4a98317cf6f76bbf1da56bc0c9afa
Gerrit-Change-Number: 41106
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 02 Jun 2020 21:13:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment