Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55024 )
Change subject: arch/x86/include/bert_storage: introduce and use bert_generate_ssdt
......................................................................
Patch Set 2:
(1 comment)
File src/arch/x86/include/arch/bert_storage.h:
https://review.coreboot.org/c/coreboot/+/55024/comment/e9b50311_a2c21f82
PS2, Line 60: bert_generate_ssdt
good point. […]
I don't understand this naming in the first place. SSDT and BERT are two completely different types of ACPI tables. SSDT is Secondary System Descriptor Table, and it is special because there can be multiple SSDTs and also because they can contain executable bytecode and data (like the DSDT); all the other tables, BERT included, are just data tables.
See Table 5.5 in the latest ACPI 6.4 spec to show the list of different types of tables
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55024
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia955f627c190ea38e05b5aaedc7cb2d030274e83
Gerrit-Change-Number: 55024
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 01 Jun 2021 21:50:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment