Change in coreboot[master]: mb/google/hatch/variants/helios: Update DPTF parameters and TDP PL1/PL2
Hank Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34743 )
Change subject: mb/google/hatch/variants/helios: Update DPTF parameters and TDP PL1/PL2 ......................................................................
Patch Set 2:
(1 comment)
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34743/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/34743/1/src/mainboard/google/hatch/... PS1, Line 37: 13000
Please, address this above comment. Thanks.
In RFQ, it is evaluated that the system must conform to the "Skin pass" state, and the CPU wattage needs to be below 10w. The current setting is PL1: 8/13w. There are two factors for 13w. 1. Thermal module capacity considerations 2. Avoid the sudden drop of wattage, resulting in the drop of test score After discussing with ASUS customers, import EVT first with PL1:8/13w settings. DVT verification will be adjusted according to the situation.
-
Hank Lin (Code Review)