Attention is currently required from: Felix Singer, Subrata Banik, Tim Wawrzynczak, EricR Lai. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60725 )
Change subject: mb/google/{drallion, hatch. sarien}: Rework CSE dt policy ......................................................................
Patch Set 3: Code-Review+1
(5 comments)
File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/60725/comment/4d44501b_1df7b496 PS3, Line 414: nit: add another space to preserve alignment
File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/60725/comment/35393707_0daf43b5 PS3, Line 32: select DISABLE_CSE_AT_PRE_BOOT Hatch and Puff use the same devicetree, shouldn't this be selected from `BOARD_GOOGLE_HATCH_COMMON`?
File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/60725/comment/f49bd67f_89996460 PS3, Line 299: nit: add another space to preserve alignment
File src/mainboard/google/sarien/variants/arcada/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/60725/comment/bdc5efa3_2f23e53e PS3, Line 345: nit: add another space to preserve alignment
File src/mainboard/google/sarien/variants/sarien/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/60725/comment/d7405d36_7b732c0d PS3, Line 366: nit: add another space to preserve alignment
-
Angel Pons (Code Review)