Attention is currently required from: Anil Kumar K, Tim Wawrzynczak, Paul Menzel, Andrey Petrov, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59638 )
Change subject: [WIP] drivers/intel/fsp2_0: Add support for FSP_NON_VOLATILE_STORAGE_HOB2
......................................................................
Patch Set 21:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59638/comment/a772d713_9257fdc1
PS21, Line 7: [WIP]
remove [WIP] to fit the commit msg
https://review.coreboot.org/c/coreboot/+/59638/comment/3204e63e_8046b2ba
PS21, Line 9: FSP 2.3 spec introduced new HOB version for NV data storage. This patch
: implements the changes to support this new HOB structure
nit: help to write the purpose of this CL and the fall back path with older FSP spec.
File src/drivers/intel/fsp2_0/include/fsp/util.h:
https://review.coreboot.org/c/coreboot/+/59638/comment/dbed548d_9a4cbc3d
PS21, Line 15: #include <efi/efi_datatype.h>
order please ?
File src/drivers/intel/fsp2_0/include/fsp/util.h:
https://review.coreboot.org/c/coreboot/+/59638/comment/5ebf39f7_a685de1f
PS19, Line 31: uint64_t
Hi Subrata. Added new CL for EFI_PHYSICAL_ADDRESS typedef […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59638
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27647e9ac1a4902256b3f1c34b60e1f0b787a06e
Gerrit-Change-Number: 59638
Gerrit-PatchSet: 21
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-CC: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 05 Jan 2022 06:39:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anil Kumar K
anil.kumar.k@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment