Attention is currently required from: Sean Rhodes, Furquan Shaikh, Angel Pons.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57149 )
Change subject: soc/tigerlake: Don't send CSE EOP if CSME is disabled
......................................................................
Patch Set 10:
(2 comments)
Patchset:
PS10:
Much better approach! 😊
One small addition for CSE Lite SKU
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/57149/comment/acb14c69_8b119ff2
PS10, Line 111: return CSE_EOP_RESULT_DISABLED;
One last thing, please modify like so:
```
if (CONFIG(SOC_INTEL_CSE_LITE_SKU))
return CSE_EOP_RESULT_ERROR;
return CSE_EOP_RESULT_DISABLED;
```
The CSE Lite case always expects the prerequisites to be met, therefore we would still like the error case to happen.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57149
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic00fdb0d97fefac977c0878d1d5893d07d4481ea
Gerrit-Change-Number: 57149
Gerrit-PatchSet: 10
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
admin@starlabs.systems
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 01 Sep 2021 19:25:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment