Attention is currently required from: Felix Singer, Tim Wawrzynczak, Michael Niewöhner.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60545 )
Change subject: soc/intel/tigerlake: Hook up FSP hyper-threading setting to option API
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/tigerlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/60545/comment/c0ab36a8_38f10417
PS6, Line 25: m_cfg->HyperThreading = get_uint_option("hyper_threading", CONFIG(FSP_HYPERTHREADING))
A setting that can be changed isn't obsolete […]
Just re-read it, ignore me - I was having a moment :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60545
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I49bbd4a776b4e6c55cb373bbf88a3ca076342e3e
Gerrit-Change-Number: 60545
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Sat, 30 Apr 2022 20:25:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Gerrit-MessageType: comment