Attention is currently required from: Shelley Chen, Angel Pons. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60806 )
Change subject: mb/google/herobrine: Remove unneeded static keyword ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/60806/comment/9427675c_5e9990dd PS1, Line 10: they are being reinitialized at the beginning of each : function anyway I think 'static int i = 0;' will be only initialized one time, and won't be re-initialized when re-entered; so the code is actually working fine. Try this:
int p() { static int i = 0; return i++; }
int main() { printf("%d\n", p()); printf("%d\n", p()); printf("%d\n", p()); return 0; }
It should give you "0 1 2", not "0 0 0".