Attention is currently required from: Lean Sheng Tan, Martin L Roth, Sean Rhodes, Stefan Reinauer.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78636?usp=email )
Change subject: payloads/edk2: Remove the warning about edk2/master not working
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Is this just the commit that happened to be tested? This is just printed for debugging, I can't really see how it would break the boot (unless there's an invalid MTRR number requested, and the CPU misbehaves. Maybe AMD implements MTRRs differently). Besides, it's inside DEBUG_CODE_BEGIN() and DEBUG_CODE_END(), so (per upstream's UefiPayloadPkg.dsc) the preprocessor strips it out for the 'CBMEM console + RELEASE' build.
Aside, we should probably stop changing behaviour between DEBUG/RELEASE, it creates so much confusion about how "this ASSERT is only breaking/a problem for DEBUG builds"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78636?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8350f5114445d2608861ef6e807f958e598dfe07
Gerrit-Change-Number: 78636
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Mon, 30 Oct 2023 19:52:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment