Change in coreboot[master]: [WIP] arch/x86: Drop TSC_SYNC_MFENCE and TSC_SYNC_LFENCE

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34229 )

Change subject: [WIP] arch/x86: Drop TSC_SYNC_MFENCE and TSC_SYNC_LFENCE
......................................................................

[WIP] arch/x86: Drop TSC_SYNC_MFENCE and TSC_SYNC_LFENCE

Change-Id: Ib712fa2c10931da90062bd853318079d5c144f48
Signed-off-by: Kyösti Mälkki 
---
M src/cpu/amd/agesa/Kconfig
M src/cpu/amd/family_10h-family_15h/Kconfig
M src/cpu/amd/pi/Kconfig
M src/cpu/intel/fsp_model_406dx/Kconfig
M src/cpu/intel/haswell/Kconfig
M src/cpu/intel/model_1067x/Kconfig
M src/cpu/intel/model_106cx/Kconfig
M src/cpu/intel/model_2065x/Kconfig
M src/cpu/intel/model_206ax/Kconfig
M src/cpu/intel/model_6ex/Kconfig
M src/cpu/intel/model_6fx/Kconfig
M src/cpu/x86/Kconfig
M src/include/cpu/x86/tsc.h
M src/soc/amd/picasso/Kconfig
M src/soc/amd/stoneyridge/Kconfig
M src/soc/intel/baytrail/Kconfig
M src/soc/intel/braswell/Kconfig
M src/soc/intel/broadwell/Kconfig
M src/soc/intel/denverton_ns/Kconfig
M src/soc/intel/fsp_baytrail/Kconfig
M src/soc/intel/skylake/Kconfig
21 files changed, 4 insertions(+), 37 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/34229/1

diff --git a/src/cpu/amd/agesa/Kconfig b/src/cpu/amd/agesa/Kconfig
index 2b8a8c7..af6605e 100644
--- a/src/cpu/amd/agesa/Kconfig
+++ b/src/cpu/amd/agesa/Kconfig
@@ -25,7 +25,6 @@
    select ARCH_ROMSTAGE_X86_32
    select ARCH_RAMSTAGE_X86_32
    select DRIVERS_AMD_PI
-	select TSC_SYNC_LFENCE
    select LAPIC_MONOTONIC_TIMER
    select SPI_FLASH if HAVE_ACPI_RESUME
    select POSTCAR_STAGE
diff --git a/src/cpu/amd/family_10h-family_15h/Kconfig b/src/cpu/amd/family_10h-family_15h/Kconfig
index 98be6f6..eff4e18 100644
--- a/src/cpu/amd/family_10h-family_15h/Kconfig
+++ b/src/cpu/amd/family_10h-family_15h/Kconfig
@@ -5,7 +5,6 @@
    select ARCH_ROMSTAGE_X86_32
    select ARCH_RAMSTAGE_X86_32
    select SSE2
-	select TSC_SYNC_LFENCE
    select SUPPORT_CPU_UCODE_IN_CBFS
    select CPU_MICROCODE_MULTIPLE_FILES
    select ACPI_HUGE_LOWMEM_BACKUP
diff --git a/src/cpu/amd/pi/Kconfig b/src/cpu/amd/pi/Kconfig
index 099f54c..d760cf9 100644
--- a/src/cpu/amd/pi/Kconfig
+++ b/src/cpu/amd/pi/Kconfig
@@ -24,7 +24,6 @@
    select ARCH_ROMSTAGE_X86_32
    select ARCH_RAMSTAGE_X86_32
    select DRIVERS_AMD_PI
-	select TSC_SYNC_LFENCE
    select LAPIC_MONOTONIC_TIMER
    select SPI_FLASH if HAVE_ACPI_RESUME
    select POSTCAR_STAGE if !BINARYPI_LEGACY_WRAPPER
diff --git a/src/cpu/intel/fsp_model_406dx/Kconfig b/src/cpu/intel/fsp_model_406dx/Kconfig
index 0aab0a2..2627265 100644
--- a/src/cpu/intel/fsp_model_406dx/Kconfig
+++ b/src/cpu/intel/fsp_model_406dx/Kconfig
@@ -31,7 +31,6 @@
    select SUPPORT_CPU_UCODE_IN_CBFS
    select MICROCODE_BLOB_NOT_IN_BLOB_REPO
    select PARALLEL_CPU_INIT
-	select TSC_SYNC_MFENCE
    select TSC_MONOTONIC_TIMER
    select CPU_INTEL_COMMON
    select CPU_INTEL_COMMON_TIMEBASE
diff --git a/src/cpu/intel/haswell/Kconfig b/src/cpu/intel/haswell/Kconfig
index 84a2241..127e8ce 100644
--- a/src/cpu/intel/haswell/Kconfig
+++ b/src/cpu/intel/haswell/Kconfig
@@ -16,7 +16,6 @@
    select TSC_MONOTONIC_TIMER
    select SUPPORT_CPU_UCODE_IN_CBFS
    #select AP_IN_SIPI_WAIT
-	select TSC_SYNC_MFENCE
    select CPU_INTEL_FIRMWARE_INTERFACE_TABLE
    select PARALLEL_MP
    select CPU_INTEL_COMMON
diff --git a/src/cpu/intel/model_1067x/Kconfig b/src/cpu/intel/model_1067x/Kconfig
index 2399c41..f1033fa 100644
--- a/src/cpu/intel/model_1067x/Kconfig
+++ b/src/cpu/intel/model_1067x/Kconfig
@@ -7,7 +7,6 @@
    select SMP
    select SSE2
    select TSC_MONOTONIC_TIMER
-	select TSC_SYNC_MFENCE
    select SUPPORT_CPU_UCODE_IN_CBFS
    select CPU_INTEL_COMMON
    select CPU_INTEL_COMMON_TIMEBASE
diff --git a/src/cpu/intel/model_106cx/Kconfig b/src/cpu/intel/model_106cx/Kconfig
index 2d6a387..8333e1d 100644
--- a/src/cpu/intel/model_106cx/Kconfig
+++ b/src/cpu/intel/model_106cx/Kconfig
@@ -9,7 +9,6 @@
    select TSC_MONOTONIC_TIMER
    select SIPI_VECTOR_IN_ROM
    select AP_IN_SIPI_WAIT
-	select TSC_SYNC_MFENCE
    select SUPPORT_CPU_UCODE_IN_CBFS
    select SERIALIZED_SMM_INITIALIZATION
    select CPU_INTEL_COMMON
diff --git a/src/cpu/intel/model_2065x/Kconfig b/src/cpu/intel/model_2065x/Kconfig
index 6c65907..8c9c5a1 100644
--- a/src/cpu/intel/model_2065x/Kconfig
+++ b/src/cpu/intel/model_2065x/Kconfig
@@ -15,7 +15,6 @@
    select SUPPORT_CPU_UCODE_IN_CBFS
    select PARALLEL_CPU_INIT
    #select AP_IN_SIPI_WAIT
-	select TSC_SYNC_MFENCE
    select CPU_INTEL_COMMON
    select CPU_INTEL_COMMON_TIMEBASE
    select NO_FIXED_XIP_ROM_SIZE
diff --git a/src/cpu/intel/model_206ax/Kconfig b/src/cpu/intel/model_206ax/Kconfig
index 4ed1119..6117480 100644
--- a/src/cpu/intel/model_206ax/Kconfig
+++ b/src/cpu/intel/model_206ax/Kconfig
@@ -15,7 +15,6 @@
    select TSC_MONOTONIC_TIMER
    select SUPPORT_CPU_UCODE_IN_CBFS
    #select AP_IN_SIPI_WAIT
-	select TSC_SYNC_MFENCE
    select CPU_INTEL_COMMON
    select CPU_INTEL_COMMON_TIMEBASE
    select CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM
diff --git a/src/cpu/intel/model_6ex/Kconfig b/src/cpu/intel/model_6ex/Kconfig
index 49f4302..a4c3ce2 100644
--- a/src/cpu/intel/model_6ex/Kconfig
+++ b/src/cpu/intel/model_6ex/Kconfig
@@ -8,7 +8,6 @@
    select SSE2
    select TSC_MONOTONIC_TIMER
    select AP_IN_SIPI_WAIT
-	select TSC_SYNC_MFENCE
    select SUPPORT_CPU_UCODE_IN_CBFS
    select CPU_INTEL_COMMON
    select CPU_INTEL_COMMON_TIMEBASE
diff --git a/src/cpu/intel/model_6fx/Kconfig b/src/cpu/intel/model_6fx/Kconfig
index b31b01d..3724cc1 100644
--- a/src/cpu/intel/model_6fx/Kconfig
+++ b/src/cpu/intel/model_6fx/Kconfig
@@ -8,7 +8,6 @@
    select SSE2
    select TSC_MONOTONIC_TIMER
    select AP_IN_SIPI_WAIT
-	select TSC_SYNC_MFENCE
    select SUPPORT_CPU_UCODE_IN_CBFS
    select CPU_INTEL_COMMON
    select CPU_INTEL_COMMON_TIMEBASE
diff --git a/src/cpu/x86/Kconfig b/src/cpu/x86/Kconfig
index 0bf2f0d..dd7c8d9 100644
--- a/src/cpu/x86/Kconfig
+++ b/src/cpu/x86/Kconfig
@@ -30,22 +30,6 @@
    help
      Expose monotonic time using the TSC.

-config TSC_SYNC_LFENCE
-	bool
-	default n
-	help
-	  The CPU driver should select this if the CPU needs
-	  to execute an lfence instruction in order to synchronize
-	  rdtsc. This is true for all modern AMD CPUs.
-
-config TSC_SYNC_MFENCE
-	bool
-	default n
-	help
-	  The CPU driver should select this if the CPU needs
-	  to execute an mfence instruction in order to synchronize
-	  rdtsc. This is true for all modern Intel CPUs.
-
 config NO_FIXED_XIP_ROM_SIZE
    bool
    default n
diff --git a/src/include/cpu/x86/tsc.h b/src/include/cpu/x86/tsc.h
index 23b74b2..8b7807b 100644
--- a/src/include/cpu/x86/tsc.h
+++ b/src/include/cpu/x86/tsc.h
@@ -3,10 +3,12 @@

#include <stdint.h>

-#if CONFIG(TSC_SYNC_MFENCE)
+#if CONFIG(CPU_INTEL_COMMON)
 #define TSC_SYNC "mfence\n"
-#elif CONFIG(TSC_SYNC_LFENCE)
+#elif CONFIG(DRIVERS_AMD_PI) || CONFIG(CPU_AMD_MODEL_10XXX)
 #define TSC_SYNC "lfence\n"
+#elif CONFIG(TSC_MONOTONIC_TIMER)
+#error "Undefined rdtsc() fence"
 #else
 #define TSC_SYNC
 #endif
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig
index d654e94..6f46706 100644
--- a/src/soc/amd/picasso/Kconfig
+++ b/src/soc/amd/picasso/Kconfig
@@ -35,7 +35,6 @@
    select IOAPIC
    select HAVE_USBDEBUG_OPTIONS
    select SPI_FLASH if HAVE_ACPI_RESUME
-	select TSC_SYNC_LFENCE
    select COLLECT_TIMESTAMPS
    select SOC_AMD_PI
    select SOC_AMD_COMMON
diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig
index 465df60..622fad9 100644
--- a/src/soc/amd/stoneyridge/Kconfig
+++ b/src/soc/amd/stoneyridge/Kconfig
@@ -39,7 +39,6 @@
    select IOAPIC
    select HAVE_USBDEBUG_OPTIONS
    select SPI_FLASH if HAVE_ACPI_RESUME
-	select TSC_SYNC_LFENCE
    select COLLECT_TIMESTAMPS
    select SOC_AMD_PI
    select SOC_AMD_COMMON
diff --git a/src/soc/intel/baytrail/Kconfig b/src/soc/intel/baytrail/Kconfig
index 46ef898..29be910 100644
--- a/src/soc/intel/baytrail/Kconfig
+++ b/src/soc/intel/baytrail/Kconfig
@@ -28,7 +28,6 @@
    select SPI_FLASH
    select SSE2
    select TSC_MONOTONIC_TIMER
-	select TSC_SYNC_MFENCE
    select SOC_INTEL_COMMON
    select INTEL_DESCRIPTOR_MODE_CAPABLE
    select HAVE_SPI_CONSOLE_SUPPORT
diff --git a/src/soc/intel/braswell/Kconfig b/src/soc/intel/braswell/Kconfig
index 5d2a776..bf8133b 100644
--- a/src/soc/intel/braswell/Kconfig
+++ b/src/soc/intel/braswell/Kconfig
@@ -37,7 +37,6 @@
    select SPI_FLASH
    select SSE2
    select TSC_MONOTONIC_TIMER
-	select TSC_SYNC_MFENCE
    select USE_GENERIC_FSP_CAR_INC
    select INTEL_DESCRIPTOR_MODE_CAPABLE
    select HAVE_SPI_CONSOLE_SUPPORT
diff --git a/src/soc/intel/broadwell/Kconfig b/src/soc/intel/broadwell/Kconfig
index 6bec847..663dbdc 100644
--- a/src/soc/intel/broadwell/Kconfig
+++ b/src/soc/intel/broadwell/Kconfig
@@ -28,7 +28,6 @@
    select SMP
    select SPI_FLASH
    select SSE2
-	select TSC_SYNC_MFENCE
    select SOC_INTEL_COMMON
    select INTEL_DESCRIPTOR_MODE_CAPABLE
    select SOC_INTEL_COMMON_ACPI_WAKE_SOURCE
diff --git a/src/soc/intel/denverton_ns/Kconfig b/src/soc/intel/denverton_ns/Kconfig
index 3bf608e..d9b86b9 100644
--- a/src/soc/intel/denverton_ns/Kconfig
+++ b/src/soc/intel/denverton_ns/Kconfig
@@ -53,7 +53,6 @@
    select SOC_INTEL_COMMON_BLOCK_GPIO
    select SOC_INTEL_COMMON_BLOCK_PCR
    select TSC_MONOTONIC_TIMER
-	select TSC_SYNC_MFENCE
    select UDK_2015_BINDING
    select CPU_INTEL_FIRMWARE_INTERFACE_TABLE

diff --git a/src/soc/intel/fsp_baytrail/Kconfig b/src/soc/intel/fsp_baytrail/Kconfig
index 38777c5..820b396 100644
--- a/src/soc/intel/fsp_baytrail/Kconfig
+++ b/src/soc/intel/fsp_baytrail/Kconfig
@@ -36,7 +36,6 @@
    select SMP
    select SPI_FLASH
    select SSE2
-	select TSC_SYNC_MFENCE
    select TSC_MONOTONIC_TIMER
    select SUPPORT_CPU_UCODE_IN_CBFS
    select MICROCODE_BLOB_NOT_HOOKED_UP
diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig
index 3d7a530..94b6585 100644
--- a/src/soc/intel/skylake/Kconfig
+++ b/src/soc/intel/skylake/Kconfig
@@ -75,7 +75,6 @@
    select SSE2
    select SUPPORT_CPU_UCODE_IN_CBFS
    select TSC_MONOTONIC_TIMER
-	select TSC_SYNC_MFENCE

config CPU_INTEL_NUM_FIT_ENTRIES
    int

[Kyösti Mälkki (Code Review)]

Hello Patrick Rudolph, Vanny E, Huang Jin, Philipp Deppenwiese, build bot (Jenkins), David Guckian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34229

to look at the new patch set (#6).

Change subject: [WIP] arch/x86: Drop TSC_SYNC_MFENCE and TSC_SYNC_LFENCE
......................................................................

[WIP] arch/x86: Drop TSC_SYNC_MFENCE and TSC_SYNC_LFENCE

Change-Id: Ib712fa2c10931da90062bd853318079d5c144f48
Signed-off-by: Kyösti Mälkki 
---
M src/cpu/amd/agesa/Kconfig
M src/cpu/amd/family_10h-family_15h/Kconfig
M src/cpu/amd/pi/Kconfig
M src/cpu/intel/fsp_model_406dx/Kconfig
M src/cpu/intel/haswell/Kconfig
M src/cpu/intel/model_1067x/Kconfig
M src/cpu/intel/model_106cx/Kconfig
M src/cpu/intel/model_2065x/Kconfig
M src/cpu/intel/model_206ax/Kconfig
M src/cpu/intel/model_6ex/Kconfig
M src/cpu/intel/model_6fx/Kconfig
M src/cpu/x86/Kconfig
M src/include/cpu/x86/tsc.h
M src/soc/amd/picasso/Kconfig
M src/soc/amd/stoneyridge/Kconfig
M src/soc/intel/baytrail/Kconfig
M src/soc/intel/braswell/Kconfig
M src/soc/intel/broadwell/Kconfig
M src/soc/intel/denverton_ns/Kconfig
M src/soc/intel/fsp_baytrail/Kconfig
M src/soc/intel/skylake/Kconfig
21 files changed, 4 insertions(+), 37 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/34229/6

[Kyösti Mälkki (Code Review)]

Hello Patrick Rudolph, Vanny E, Huang Jin, Philipp Deppenwiese, build bot (Jenkins), David Guckian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34229

to look at the new patch set (#7).

Change subject: [WIP] arch/x86: Drop TSC_SYNC_MFENCE and TSC_SYNC_LFENCE
......................................................................

[WIP] arch/x86: Drop TSC_SYNC_MFENCE and TSC_SYNC_LFENCE

Change-Id: Ib712fa2c10931da90062bd853318079d5c144f48
Signed-off-by: Kyösti Mälkki 
---
M src/cpu/amd/agesa/Kconfig
M src/cpu/amd/family_10h-family_15h/Kconfig
M src/cpu/amd/pi/Kconfig
M src/cpu/intel/fsp_model_406dx/Kconfig
M src/cpu/intel/haswell/Kconfig
M src/cpu/intel/model_1067x/Kconfig
M src/cpu/intel/model_106cx/Kconfig
M src/cpu/intel/model_2065x/Kconfig
M src/cpu/intel/model_206ax/Kconfig
M src/cpu/intel/model_6ex/Kconfig
M src/cpu/intel/model_6fx/Kconfig
M src/cpu/x86/Kconfig
M src/include/cpu/x86/tsc.h
M src/soc/amd/picasso/Kconfig
M src/soc/amd/stoneyridge/Kconfig
M src/soc/intel/baytrail/Kconfig
M src/soc/intel/braswell/Kconfig
M src/soc/intel/broadwell/Kconfig
M src/soc/intel/denverton_ns/Kconfig
M src/soc/intel/fsp_baytrail/Kconfig
M src/soc/intel/skylake/Kconfig
21 files changed, 4 insertions(+), 37 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/34229/7

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34229 )

Change subject: [WIP] arch/x86: Drop TSC_SYNC_MFENCE and TSC_SYNC_LFENCE
......................................................................

Abandoned