Attention is currently required from: Anson Tseng, Frank Chu, Nick Vaccaro, Zhuohao Lee.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59557 )
Change subject: mb/google/volteer/var/delbin: Add fw_config probe for ALC5682-VD & VS
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
File src/mainboard/google/volteer/variants/delbin/variant.c:
https://review.coreboot.org/c/coreboot/+/59557/comment/359182ca_0a2f9114
PS6, Line 7:
: extern struct chip_operations drivers_i2c_generic_ops;
: static void audio_codec_update(void)
: {
: const struct device_path codec_path[] = {
: {.type = DEVICE_PATH_PCI, .pci.devfn = PCH_DEVFN_I2C0},
: {.type = DEVICE_PATH_I2C, .i2c.device = 0x1a}
: };
: const struct device *codec =
: find_dev_nested_path(pci_root_bus(), codec_path, ARRAY_SIZE(codec_path));
: struct drivers_i2c_generic_config *config;
:
: if (!codec || (codec->chip_ops != &drivers_i2c_generic_ops) || !codec->chip_info)
: return;
: config = codec->chip_info;
:
: if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682)))
: config->hid = "10EC5682";
: else if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682I_VS)))
: config->hid = "RTL5682";
+Nick, do you want to cherry-pick the stack starting https://review.coreboot. […]
Guess not.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59557
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieef638f78edd3428e572a76f06fb9c8757278971
Gerrit-Change-Number: 59557
Gerrit-PatchSet: 7
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Anson Tseng
ansontseng@google.com
Gerrit-Reviewer: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Anson Tseng
ansontseng@google.com
Gerrit-Attention: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Wed, 05 Jan 2022 02:39:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment