Change in coreboot[master]: tests: Add lib/nhlt-test test case - coreboot-gerrit

26 Oct 2021


      Attention is currently required from: Naveen M, Furquan Shaikh, Jakub Czapiga, Paul Fagerburg, Subrata Banik, Jan Dabros, Sathya Prakash M R, Sathyanarayana Nujella.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57530 )
Change subject: tests: Add lib/nhlt-test test case
......................................................................
Patch Set 3:
(1 comment)
File tests/lib/nhlt-test.c:
https://review.coreboot.org/c/coreboot/+/57530/comment/c6ee0f00_f6e17104 
PS1, Line 1368: oem_id
...
So, what should I do? (ping)
I'm not sure if that's what Subrata means, but in coreboot code, we fill oem_id with stuff like "GOOGLE", "INTEL" or "SCRDMAX". pick one of these?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57530
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c613450ab36a29fa85e98798baac4e863ad0cd3
Gerrit-Change-Number: 57530
Gerrit-PatchSet: 3
Gerrit-Owner: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Naveen M naveen.m@intel.com
Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: Sathya Prakash M R sathya.prakash.m.r@intel.com
Gerrit-Reviewer: Sathyanarayana Nujella
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jan Dabros jsd@semihalf.com
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Naveen M naveen.m@intel.com
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Jakub Czapiga jacz@semihalf.com
Gerrit-Attention: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Jan Dabros jsd@semihalf.com
Gerrit-Attention: Sathya Prakash M R sathya.prakash.m.r@intel.com
Gerrit-Attention: Sathyanarayana Nujella
Gerrit-Comment-Date: Tue, 26 Oct 2021 17:43:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga jacz@semihalf.com
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Gerrit-MessageType: comment