Attention is currently required from: David Wu, Eric Lai, Karthik Ramasubramanian, Nick Vaccaro, Ren Kuo, Subrata Banik, Tyler Wang.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78791?usp=email )
Change subject: mb/google/nissa: Add AUDIO_CONFIG in fw_config
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78791/comment/6a1af0eb_4e5028b3 :
PS1, Line 10: deptcharge
depthcharge
https://review.coreboot.org/c/coreboot/+/78791/comment/bb7a67d5_e5c56673 :
PS1, Line 10: .S
Add a space
File src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/78791/comment/fdf41e6b_95caf138 :
PS1, Line 4: AMP_I2S
Please rename this to AMP_RT5650. The config is specific to RT5650, and if we ever support other non-GPIO AMPs on nissa they will need their own config.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78791?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7446fce57557204d91151f1a31755381c1813c6f
Gerrit-Change-Number: 78791
Gerrit-PatchSet: 1
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sam McNally
sammc@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 31 Oct 2023 00:13:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment