Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, V Sowmya, Vidya Gopalakrishnan, Vinay Kumar.
Subrata Banik has posted comments on this change by Vidya Gopalakrishnan. ( https://review.coreboot.org/c/coreboot/+/85184?usp=email )
Change subject: mb/google/brya/var/trulo: Update PL1 values as per silicon TDP
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/trulo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85184/comment/72c452d6_0c997eaa?usp... :
PS4, Line 184: register "power_limits_config[ADL_N_041_6W_CORE]" = "{
: .tdp_pl1_override = 20,
: .tdp_pl2_override = 25,
: .tdp_pl4 = 78,
: }"
:
: register "power_limits_config[ADL_N_081_7W_CORE]" = "{
: .tdp_pl1_override = 20,
: .tdp_pl2_override = 25,
: .tdp_pl4 = 78,
: }"
:
: register "power_limits_config[ADL_N_081_15W_CORE]" = "{
: .tdp_pl1_override = 20,
: .tdp_pl2_override = 35,
: .tdp_pl4 = 83,
: }"
wondering if your goal is to block PLx overrides which I felt is something that many ODMs are using at present.
you are updating the defined power limits which is okay but why you would like to avoid any hooks to perform Plx override ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85184?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I798c4f10e10a579f470e00dbdb77a84619ad796a
Gerrit-Change-Number: 85184
Gerrit-PatchSet: 4
Gerrit-Owner: Vidya Gopalakrishnan
vidya.gopalakrishnan@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Vidya Gopalakrishnan
vidya.gopalakrishnan@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Comment-Date: Thu, 21 Nov 2024 10:04:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No