Change in coreboot[master]: mb/google/drallion: Increase Melfas touchscreen reset delay to 115ms

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

John Su (Code Review)

14 Apr 2020 14 Apr '20

9:43 a.m.

John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40357 )

Change subject: mb/google/drallion: Increase Melfas touchscreen reset delay to 115ms ......................................................................

mb/google/drallion: Increase Melfas touchscreen reset delay to 115ms

Modify reset_delay_ms as 115ms to waiting for Melfas device I2C interface ready after touch fw auto update and rebind driver.

BUG=b:153708773 BRANCH=drallion

Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: Ib392190d2b4188ee228d8ca4873e03176d2f127f --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/40357/1

diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 60be8c9..a732f5d 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -386,7 +386,7 @@ register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)" register "probed" = "1" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "reset_delay_ms" = "10" + register "reset_delay_ms" = "115" register "reset_off_delay_ms" = "5" register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" register "stop_delay_ms" = "10"

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

John Su (Code Review)

16 Apr 16 Apr

7:12 a.m.

New subject: Change in coreboot[master]: mb/google/drallion: Increase Melfas touchscreen stop delay to 115ms

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40357 )

Change subject: mb/google/drallion: Increase Melfas touchscreen stop delay to 115ms ......................................................................

Patch Set 4:

This change is ready for review.

Paul Menzel (Code Review)

9:47 a.m.

New subject: Change in coreboot[master]: mb/google/drallion: Increase Melfas touchscreen stop delay to 115ms

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40357 )

Change subject: mb/google/drallion: Increase Melfas touchscreen stop delay to 115ms ......................................................................

Patch Set 4: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/40357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib392190d2b4188ee228d8ca4873e03176d2f127f Gerrit-Change-Number: 40357 Gerrit-PatchSet: 4 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-Comment-Date: Thu, 16 Apr 2020 09:47:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Alan Lee (Code Review)

20 Apr 20 Apr

1:51 a.m.

New subject: Change in coreboot[master]: mb/google/drallion: Increase Melfas touchscreen stop delay to 115ms

Alan Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40357 )

Change subject: mb/google/drallion: Increase Melfas touchscreen stop delay to 115ms ......................................................................

Patch Set 4:

Hi Google, we need this CL into FW branch for R83 FSI if you do not have any concern. Please help to review it. Thanks.

-- To view, visit https://review.coreboot.org/c/coreboot/+/40357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib392190d2b4188ee228d8ca4873e03176d2f127f Gerrit-Change-Number: 40357 Gerrit-PatchSet: 4 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Mon, 20 Apr 2020 01:51:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Mathew King (Code Review)

2:46 a.m.

New subject: Change in coreboot[master]: mb/google/drallion: Increase Melfas touchscreen stop delay to 115ms

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40357 )

Change subject: mb/google/drallion: Increase Melfas touchscreen stop delay to 115ms ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/40357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib392190d2b4188ee228d8ca4873e03176d2f127f Gerrit-Change-Number: 40357 Gerrit-PatchSet: 4 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Mon, 20 Apr 2020 02:46:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Duncan Laurie (Code Review)

3:19 a.m.

New subject: Change in coreboot[master]: mb/google/drallion: Increase Melfas touchscreen stop delay to 115ms

Duncan Laurie has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40357 )

Change subject: mb/google/drallion: Increase Melfas touchscreen stop delay to 115ms ......................................................................

mb/google/drallion: Increase Melfas touchscreen stop delay to 115ms

Modify stop_delay as 115ms to waiting for Melfas device I2C interface ready after touch fw auto update and rebind driver.

BUG=b:153708773 BRANCH=drallion

Signed-off-by: John Su john_su@compal.corp-partner.google.com Change-Id: Ib392190d2b4188ee228d8ca4873e03176d2f127f Reviewed-on: https://review.coreboot.org/c/coreboot/+/40357 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Mathew King mathewk@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/drallion/variants/drallion/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Mathew King: Looks good to me, approved

diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb index 60be8c9..9bb09ab 100644 --- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb +++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb @@ -389,7 +389,7 @@ register "reset_delay_ms" = "10" register "reset_off_delay_ms" = "5" register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E7)" - register "stop_delay_ms" = "10" + register "stop_delay_ms" = "115" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B21)" register "enable_delay_ms" = "55" register "has_power_resource" = "1"

-- To view, visit https://review.coreboot.org/c/coreboot/+/40357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib392190d2b4188ee228d8ca4873e03176d2f127f Gerrit-Change-Number: 40357 Gerrit-PatchSet: 5 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: merged

9elements QA (Code Review)

3:34 a.m.

New subject: Change in coreboot[master]: mb/google/drallion: Increase Melfas touchscreen stop delay to 115ms

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40357 )

Change subject: mb/google/drallion: Increase Melfas touchscreen stop delay to 115ms ......................................................................

Patch Set 5:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2474 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2473 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2472 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/2471

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/40357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib392190d2b4188ee228d8ca4873e03176d2f127f Gerrit-Change-Number: 40357 Gerrit-PatchSet: 5 Gerrit-Owner: John Su john_su@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Mathew King mathewk@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com Gerrit-CC: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Mon, 20 Apr 2020 03:34:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1623

days inactive

1629

days old

coreboot-gerrit@coreboot.org

6 comments

6 participants

tags (0)

participants (6)

9elements QA (Code Review)
Alan Lee (Code Review)
Duncan Laurie (Code Review)
John Su (Code Review)
Mathew King (Code Review)
Paul Menzel (Code Review)