Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22106 )
Change subject: security/tpm: Set up generic TSPI ......................................................................
Patch Set 40:
(3 comments)
https://review.coreboot.org/#/c/22106/37/src/security/vboot/antirollback.h File src/security/vboot/antirollback.h:
https://review.coreboot.org/#/c/22106/37/src/security/vboot/antirollback.h@6... PS37, Line 60: antirollb
It's vboot specific in that it takes a struct vb2_context.
ah sorry missed that. Got it wrong will fix it as well.
https://review.coreboot.org/#/c/22106/39/src/security/vboot/secdata_tpm.c File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/#/c/22106/39/src/security/vboot/secdata_tpm.c@67 PS39, Line 67: delete or modify once : * the RO exits
Note that thes attributes by themselves actually don't (and shouldn't) protect the spaces from modif […]
got it
https://review.coreboot.org/#/c/22106/39/src/security/vboot/secdata_tpm.c@20... PS39, Line 206:
As noted in the previous comment, I'd keep a different set of attributes and no delete policy for ke […]
Done
-
Philipp Deppenwiese (Code Review)