[M] Change in coreboot[master]: console: Add SimNow console logging - coreboot-gerrit

6 Feb 2023


      Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72751 )
Change subject: console: Add SimNow console logging
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/simnow/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/72751/comment/2bb4f383_1c65d1b8 
PS1, Line 6: CONFIG_AMD_SOC_CONSOLE_UART
did you mean CONFIG_CONSOLE_AMD_SIMNOW? maybe have a ifeq ($(CONFIG_CONSOLE_AMD_SIMNOW),y) around both and smm-$(CONFIG_DEBUG_SMI) += .. here
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/72751
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42a431f48ea14ba4adacbd4a32e15abe7c5e4951
Gerrit-Change-Number: 72751
Gerrit-PatchSet: 1
Gerrit-Owner: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Comment-Date: Mon, 06 Feb 2023 21:22:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment