Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45906 )
Change subject: edk2-stable202005: Update MdePkg/Include/IndustryStandard/SmBios.h
......................................................................
Patch Set 8:
(1 comment)
File src/vendorcode/intel/edk2/edk2-stable202005/MdePkg/Include/IndustryStandard/SmBios.h:
https://review.coreboot.org/c/coreboot/+/45906/comment/1999e8af_fba649b4
PS8, Line 1249: #if !CONFIG(DISPLAY_FSP_VERSION_INFO_2)
in that also there will be indicator that comes from makfile dynamically that we need to use it here […]
can we merge this ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45906
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9698861be1f969ddca7f171767a54ac486502c74
Gerrit-Change-Number: 45906
Gerrit-PatchSet: 8
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 20 Apr 2021 11:11:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-MessageType: comment