Attention is currently required from: Felix Singer, Angel Pons, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72806 )
Change subject: nb/intel/haswell/pcie.c: Make UBSAN shut up ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72806/comment/206303c4_cd34acf4 PS1, Line 10: and : the result of the operation drop
https://review.coreboot.org/c/coreboot/+/72806/comment/f1fe93ad_0adfd3a3 PS1, Line 14: integer literals are unsigned so that the shift doesn't overflow. IIRC, the undefined part is shifting into the sign bit. Technically, it's not specified in C that the MSB is the sign bit. It's just that all architectures and compilers happen to use a 2's complement representation.