[XL] Change in coreboot[main]: mb/dell: Add Dell Precision M4800 (Haswell)
Attention is currently required from: Paul Menzel. Justin Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79755?usp=email ) Change subject: mb/dell: Add Dell Precision M4800 (Haswell) ...................................................................... Patch Set 4: (3 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/79755/comment/5bf6a19d_e6d64f53 : PS3, Line 9: workstation
Is it a laptop? Correct, it is indeed a laptop. Maybe we could call it a mobile workstation?
https://review.coreboot.org/c/coreboot/+/79755/comment/9f15df36_60de4542 : PS3, Line 38: - Physical Wireless switch
What does that mean? Wifi does not work, but the system things it’s still enabled? I should clarify that these two commits are necessary for wifi to work: https://review.coreboot.org/c/coreboot/+/79011/1 and https://review.coreboot.org/c/coreboot/+/77534/7.
Without them, I believe I observed that the kernel detects the wifi card but can't enable it. Patchset: PS3:
Welcome to coreboot, and thank you for this great contribution. Thank you for the warm welcome.
-- To view, visit https://review.coreboot.org/c/coreboot/+/79755?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I49870b28be943dcb1932909f9d3ec4207cc11436 Gerrit-Change-Number: 79755 Gerrit-PatchSet: 4 Gerrit-Owner: Justin Wu <jxw5883@runbox.io> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Nicholas Chin <nic.c3.14@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org> Gerrit-Comment-Date: Mon, 01 Jan 2024 19:28:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org> Gerrit-MessageType: comment
participants (1)
-
Justin Wu (Code Review)