[M] Change in coreboot[main]: drivers/usb/acpi: Add DSM for Intel Bluetooth
Attention is currently required from: Matt DeVillier, Subrata Banik. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84133?usp=email ) Change subject: drivers/usb/acpi: Add DSM for Intel Bluetooth ...................................................................... Patch Set 5: (4 comments) File src/drivers/usb/acpi/chip.h: https://review.coreboot.org/c/coreboot/+/84133/comment/681e8e0b_8d96c7ba?usp... : PS3, Line 51: bool intel_bt;
can you please use a meaningful name ? I don't understand what you mean by `intel_bt` ? is it like ` […] Done
File src/drivers/usb/acpi/usb_acpi.c: https://review.coreboot.org/c/coreboot/+/84133/comment/f1a529bc_c968dc0d?usp... : PS3, Line 12:
just one space to start the comment Done
https://review.coreboot.org/c/coreboot/+/84133/comment/fd872506_050f5116?usp... : PS3, Line 27: 0x03
can you please explain the meaning of hard coded value ? BIT(0) and BIT(1) - supported and other functions are supported.
https://review.coreboot.org/c/coreboot/+/84133/comment/e2c365d7_3e389a6e?usp... : PS3, Line 36: /* aa10f4e0-81ac-4233-abf6-3b2ac50e28d9 */
unable to follow why you have used the GUID here ? THought it made it easier to follow - removed.
-- To view, visit https://review.coreboot.org/c/coreboot/+/84133?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icc18f867604876b27ced2ee4356e47b3aa6b4f74 Gerrit-Change-Number: 84133 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean@starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik@google.com> Gerrit-Attention: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Comment-Date: Sat, 31 Aug 2024 18:59:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik@google.com>
participants (1)
-
Sean Rhodes (Code Review)