Patrick Rudolph (siro@das-labor.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17611
-gerrit
commit 89a1c3b2a9e2c7f31ca5728f50c3796a0fc56e2f Author: Patrick Rudolph siro@das-labor.org Date: Fri Nov 25 16:36:52 2016 +0100
nb/intel/sandybridge/raminit: Reduce log level
Remove verbose logging from loops. Print detailed summary at end of loop instead. Use the same scheme already present in some functions.
Change-Id: I412d81592436ac0d2422caf396c64e0c34acc2d1 Signed-off-by: Patrick Rudolph siro@das-labor.org --- src/northbridge/intel/sandybridge/raminit_common.c | 32 ++++++---------------- 1 file changed, 8 insertions(+), 24 deletions(-)
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 6b352c2..1ecf5db 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -1222,9 +1222,6 @@ static void discover_timA_coarse(ramctr_timing * ctrl, int channel, FOR_ALL_LANES { statistics[lane][timA] = !does_lane_work(ctrl, channel, slotrank, lane); - printram("Astat: %d, %d, %d: %x, %x\n", - channel, slotrank, lane, timA, - statistics[lane][timA]); } } FOR_ALL_LANES { @@ -1233,10 +1230,8 @@ static void discover_timA_coarse(ramctr_timing * ctrl, int channel, upperA[lane] = rn.end; if (upperA[lane] < rn.middle) upperA[lane] += 128; - printram("Aval: %d, %d, %d: %x\n", channel, slotrank, - lane, ctrl->timings[channel][slotrank].lanes[lane].timA); - printram("Aend: %d, %d, %d: %x\n", channel, slotrank, - lane, upperA[lane]); + printram("timA: %d, %d, %d: 0x%02x-0x%02x-0x%02x\n", + channel, slotrank, lane, rn.start, rn.middle, rn.end); } }
@@ -1613,9 +1608,6 @@ static int discover_timC(ramctr_timing *ctrl, int channel, int slotrank) statistics[lane][timC] = read32(DEFAULT_MCHBAR + 0x4340 + 4 * lane + 0x400 * channel); - printram("Cstat: %d, %d, %d, %x, %x\n", - channel, slotrank, lane, timC, - statistics[lane][timC]); } } FOR_ALL_LANES { @@ -1627,8 +1619,8 @@ static int discover_timC(ramctr_timing *ctrl, int channel, int slotrank) channel, slotrank, lane); return MAKE_ERR; } - printram("Cval: %d, %d, %d: %x\n", channel, slotrank, - lane, ctrl->timings[channel][slotrank].lanes[lane].timC); + printram("timC: %d, %d, %d: 0x%02x-0x%02x-0x%02x\n", + channel, slotrank, lane, rn.start, rn.middle, rn.end); } return 0; } @@ -1846,9 +1838,6 @@ static int discover_timB(ramctr_timing *ctrl, int channel, int slotrank) (DEFAULT_MCHBAR + lane_registers[lane] + channel * 0x100 + 4 + ((timB / 32) & 1) * 4) >> (timB % 32)) & 1); - printram("Bstat: %d, %d, %d: %x, %x\n", - channel, slotrank, lane, timB, - statistics[lane][timB]); } } FOR_ALL_LANES { @@ -1872,8 +1861,8 @@ static int discover_timB(ramctr_timing *ctrl, int channel, int slotrank) channel, slotrank, lane); return MAKE_ERR; } - printram("Bval: %d, %d, %d: %x\n", channel, slotrank, - lane, ctrl->timings[channel][slotrank].lanes[lane].timB); + printram("timB: %d, %d, %d: 0x%02x-0x%02x-0x%02x\n", + channel, slotrank, lane, rn.start, rn.middle, rn.end); } return 0; } @@ -2217,7 +2206,6 @@ static int test_320c(ramctr_timing * ctrl, int channel, int slotrank)
ctrl->timings[channel][slotrank] = saved_rt;
- printram("3lanes: %x\n", lanes_ok); return lanes_ok != ((1 << NUM_LANES) - 1); }
@@ -2354,9 +2342,6 @@ static int try_cmd_stretch(ramctr_timing *ctrl, int channel, int cmd_stretch) FOR_ALL_POPULATED_RANKS { stat[slotrank][c320c + 127] = test_320c(ctrl, channel, slotrank); - printram("3stat: %d, %d, %d: %x\n", - channel, slotrank, c320c, - stat[slotrank][c320c + 127]); } } FOR_ALL_POPULATED_RANKS { @@ -2364,9 +2349,8 @@ static int try_cmd_stretch(ramctr_timing *ctrl, int channel, int cmd_stretch) get_longest_zero_run(stat[slotrank], 255); ctrl->timings[channel][slotrank].val_320c = rn.middle - 127; - printram("3val %d, %d: %d\n", channel, - slotrank, - ctrl->timings[channel][slotrank].val_320c); + printram("cmd_stretch: %d, %d: 0x%02x-0x%02x-0x%02x\n", + channel, slotrank, rn.start, rn.middle, rn.end); if (rn.all || rn.length < MIN_C320C_LEN) { FOR_ALL_POPULATED_RANKS { ctrl->timings[channel][slotrank] =
-
Patrick Rudolph