Change in coreboot[master]: cbfs: Remove prog_locate() for stages and rmodules - coreboot-gerrit

5 Mar 2021


      Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson, Patrick Rudolph, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49335 )
Change subject: cbfs: Remove prog_locate() for stages and rmodules
......................................................................
Patch Set 14:
(1 comment)
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/49335/comment/8d9ee8b0_8419ba11 
PS14, Line 398: 	if ((err = cbfs_boot_lookup(prog_name(pstage), false, &mdata, &rdev)))
do not use assignment in if condition
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49335
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia600e55f77c2549a00e2606f09befc1f92594a3a
Gerrit-Change-Number: 49335
Gerrit-PatchSet: 14
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 05 Mar 2021 02:36:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment