Attention is currently required from: Andrey Petrov, Felix Held, Fred Reitberger, Jason Glenesk, Johnny Lin, Kapil Porwal, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Nico Huber, Paul Menzel, Raul Rangel.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77556?usp=email )
Change subject: drivers/intel/fsp2_0: Introduce MRC cache store after FSP-M/S APIs
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
@Jonny, can I request you to pick CB:77616 and CB:77556 Cls and share your feedback.
I have verified the exclusive boot scenario related to xeon_sp where FSP-S populates the NVS data. Please take a look into the MRC cache write in successful post FSP-S.
```
First boot | Post FSP-S
[DEBUG] FMAP: area RW_MRC_CACHE found @ 1710000 (65536 bytes)
[DEBUG] MRC: Checking cached data update for 'RW_MRC_CACHE'.
[INFO ] SF: Detected 00 0000 with sector size 0x1000, total 0x4000000
[ERROR] SF size 0x4000000 does not correspond to CONFIG_ROM_SIZE 0x2000000!!
[NOTE ] MRC: no data in 'RW_MRC_CACHE'
[DEBUG] MRC: cache data 'RW_MRC_CACHE' needs update.
[DEBUG] MRC: updated 'RW_MRC_CACHE'.
[DEBUG] FMAP: area RW_ELOG found @ 1720000 (16384 bytes)
[INFO ] ELOG: NV offset 0x1720000 size 0x4000
[ERROR] ELOG: NV Buffer Cleared.
consecutive boot | Post FSP-S
[DEBUG] FMAP: area RW_MRC_CACHE found @ 1710000 (65536 bytes)
[DEBUG] MRC: Checking cached data update for 'RW_MRC_CACHE'.
[INFO ] SF: Detected 00 0000 with sector size 0x1000, total 0x4000000
[ERROR] SF size 0x4000000 does not correspond to CONFIG_ROM_SIZE 0x2000000!!
[DEBUG] MRC: 'RW_MRC_CACHE' does not need update.
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77556?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id1e91d25916594f59d1e467a142f5042c6138b51
Gerrit-Change-Number: 77556
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 02 Sep 2023 22:21:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment