Attention is currently required from: Felix Singer, Nico Huber, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72806 )
Change subject: nb/intel/haswell/pcie.c: Make UBSAN shut up ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72806/comment/8deb87ec_8dbc691a PS1, Line 10: and : the result of the operation
drop
Oops, thanks for spotting this
https://review.coreboot.org/c/coreboot/+/72806/comment/3d15b3c0_1985f794 PS1, Line 14: integer literals are unsigned so that the shift doesn't overflow.
IIRC, the undefined part is shifting into the sign bit. Technically, […]
Ah, thanks for the explanation! Tried to rewrite the commit message factoring in this information, thoughts?
-
Angel Pons (Code Review)