Change in coreboot[master]: drivers/i2c/designware: Report I2C timings for additional bus speeds
Attention is currently required from: Tim Wawrzynczak, Werner Zeh, Kyösti Mälkki. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55088 )
Change subject: drivers/i2c/designware: Report I2C timings for additional bus speeds ......................................................................
Patch Set 2:
(1 comment)
File src/drivers/i2c/designware/dw_i2c.c:
https://review.coreboot.org/c/coreboot/+/55088/comment/c597b2c1_6f2aed99 PS2, Line 834: Now check if there are more speed settings available and report them as well.
The reason I took this approach is that I would like to avoid invalid values being reported. […]
Aah okay, that makes sense. The reason I mentioned exposing all possible speeds is because at least the Linux kernel driver uses a least common denominator to choose the appropriate speed to be used for a particular bus i.e. uses the lowest speed value exposed by all devices on the given bus. It would have ensured that the kernel driver gets option to configure for any speeds depending upon the peripheral devices supported. But, what you mentioned about dummy/invalid timings also makes sense.
-
Furquan Shaikh (Code Review)