Change in ...coreboot[master]: soc/intel/common/uart: Drop dead call to soc_uart_set_legacy_mode()

[Nico Huber (Code Review)]

Hello Patrick Rudolph, Lance Zhao,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/33095

to review the following change.

Change subject: soc/intel/common/uart: Drop dead call to soc_uart_set_legacy_mode()
......................................................................

soc/intel/common/uart: Drop dead call to soc_uart_set_legacy_mode()

The only path that leads here is guarded by both !DRIVERS_UART_
8250MEM_32 and INTEL_LPSS_UART_FOR_CONSOLE but the latter selects
the former.

Change-Id: I6e0765b028572950991c45b45b2051f4f176a94a
Signed-off-by: Nico Huber 
---
M src/soc/intel/common/block/include/intelblocks/uart.h
M src/soc/intel/common/block/uart/uart.c
2 files changed, 0 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/33095/1

diff --git a/src/soc/intel/common/block/include/intelblocks/uart.h b/src/soc/intel/common/block/include/intelblocks/uart.h
index ad2ddf4..55f259d 100644
--- a/src/soc/intel/common/block/include/intelblocks/uart.h
+++ b/src/soc/intel/common/block/include/intelblocks/uart.h
@@ -91,10 +91,4 @@
  */
 struct device *soc_uart_console_to_device(int uart_console);

-/*
- * Set UART to legacy mode
- * Put UART in byte access mode for 16550 compatibility
- */
-void soc_uart_set_legacy_mode(void);
-
 #endif	/* SOC_INTEL_COMMON_BLOCK_UART_H */
diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c
index a8e5792..35c2c6c 100644
--- a/src/soc/intel/common/block/uart/uart.c
+++ b/src/soc/intel/common/block/uart/uart.c
@@ -139,10 +139,6 @@
    uart_common_init(uart_get_device(),
    	UART_BASE(CONFIG_UART_FOR_CONSOLE));

-	if (!CONFIG(DRIVERS_UART_8250MEM_32))
-		/* Put UART in byte access mode for 16550 compatibility */
-		soc_uart_set_legacy_mode();
-
    /* Configure the 2 pads per UART. */
    uart_configure_gpio_pads();
 }

[Lance Zhao (Code Review)]

Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33095 )

Change subject: soc/intel/common/uart: Drop dead call to soc_uart_set_legacy_mode()
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33095 )

Change subject: soc/intel/common/uart: Drop dead call to soc_uart_set_legacy_mode()
......................................................................

soc/intel/common/uart: Drop dead call to soc_uart_set_legacy_mode()

The only path that leads here is guarded by both !DRIVERS_UART_
8250MEM_32 and INTEL_LPSS_UART_FOR_CONSOLE but the latter selects
the former.

Change-Id: I6e0765b028572950991c45b45b2051f4f176a94a
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33095
Tested-by: build bot (Jenkins) 
Reviewed-by: Lance Zhao 
---
M src/soc/intel/common/block/include/intelblocks/uart.h
M src/soc/intel/common/block/uart/uart.c
2 files changed, 0 insertions(+), 10 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Lance Zhao: Looks good to me, approved

diff --git a/src/soc/intel/common/block/include/intelblocks/uart.h b/src/soc/intel/common/block/include/intelblocks/uart.h
index ad2ddf4..55f259d 100644
--- a/src/soc/intel/common/block/include/intelblocks/uart.h
+++ b/src/soc/intel/common/block/include/intelblocks/uart.h
@@ -91,10 +91,4 @@
  */
 struct device *soc_uart_console_to_device(int uart_console);

-/*
- * Set UART to legacy mode
- * Put UART in byte access mode for 16550 compatibility
- */
-void soc_uart_set_legacy_mode(void);
-
 #endif	/* SOC_INTEL_COMMON_BLOCK_UART_H */
diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c
index a8e5792..35c2c6c 100644
--- a/src/soc/intel/common/block/uart/uart.c
+++ b/src/soc/intel/common/block/uart/uart.c
@@ -139,10 +139,6 @@
    uart_common_init(uart_get_device(),
    	UART_BASE(CONFIG_UART_FOR_CONSOLE));

-	if (!CONFIG(DRIVERS_UART_8250MEM_32))
-		/* Put UART in byte access mode for 16550 compatibility */
-		soc_uart_set_legacy_mode();
-
    /* Configure the 2 pads per UART. */
    uart_configure_gpio_pads();
 }