Hello Martin Roth, Patrick Georgi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/48678
to review the following change.
Change subject: kconfig: remove evaluation of hex values as a boolean ......................................................................
kconfig: remove evaluation of hex values as a boolean
In kconfig, hex values when evaluated as a boolean will always be "n". Kconfiglib warns about this, whereas the C implementation just quitely treated it as "n".
Remove the evaluation of hex values as a boolean to clear up the warnings.
Signed-off-by: Jack Rosenthal jrosenth@chromium.org Change-Id: I96fde326976cd338dab1846e3a18bd8d247b1639 --- M src/security/intel/stm/Kconfig 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/48678/1
diff --git a/src/security/intel/stm/Kconfig b/src/security/intel/stm/Kconfig index 5286354..962f9ef 100644 --- a/src/security/intel/stm/Kconfig +++ b/src/security/intel/stm/Kconfig @@ -87,8 +87,7 @@
config STM_TTYS0_BASE hex "stm uart" - default TTYS0_BASE if TTYS0_BASE - default 0x000 + default TTYS0_BASE help Defines the serial port for STM console output. 0x000 indicates no serial port. @@ -105,7 +104,7 @@
config STM_CONSOLE_DEBUG bool "Debug output" - depends on STM_CBMEM_CONSOLE || STM_TTYS0_BASE + depends on STM_CBMEM_CONSOLE help "Produces all STM console output"
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48678 )
Change subject: kconfig: remove evaluation of hex values as a boolean ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48678/1/src/security/intel/stm/Kcon... File src/security/intel/stm/Kconfig:
https://review.coreboot.org/c/coreboot/+/48678/1/src/security/intel/stm/Kcon... PS1, Line 108: STM_TTYS0_BASE I guess this would translate to `STM_TTYS0_BASE != 0x0`?
Jack Rosenthal has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48678 )
Change subject: kconfig: remove evaluation of hex values as a boolean ......................................................................
Abandoned
revisit later
-
Jack Rosenthal (Code Review) -
Nico Huber (Code Review)